Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3181 - Align ingestion requirements #3182

Merged
merged 1 commit into from Mar 6, 2022
Merged

Fix #3181 - Align ingestion requirements #3182

merged 1 commit into from Mar 6, 2022

Conversation

pmbrull
Copy link
Collaborator

@pmbrull pmbrull commented Mar 6, 2022

Describe your changes :

This PR fixes #3181

  • Fix ES version, as it was just picking 7.13.1. This speeds up the process
  • Bump down redash version. 0.1.9 uses click > 8, while we are still at 7. That change might impact other dependencies in the dependency tree because it completely broke the CI pipeline. @codingwithabhi, please review that version 0.1.8 works for your latest patch as well

Thanks

Type of change :

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Frontend Preview (Screenshots) :

For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

Checklist:

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my own.
  • I have tagged my reviewers below.
  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

@sonarcloud
Copy link

sonarcloud bot commented Mar 6, 2022

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@pmbrull
Copy link
Collaborator Author

pmbrull commented Mar 6, 2022

Merging as main is broken

@pmbrull pmbrull merged commit a9290bf into open-metadata:main Mar 6, 2022
@pmbrull pmbrull deleted the issue-3181 branch March 6, 2022 08:02
@codingwithabhi
Copy link
Contributor

redash version 0.1.8 works well @pmbrull

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codingwithabhi codingwithabhi Awaiting requested review from codingwithabhi

@harshach harshach Awaiting requested review from harshach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Align ingestion requirements
2 participants
@pmbrull @codingwithabhi