Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI : New Data profiler Layout. #3184

Merged
merged 9 commits into from Mar 6, 2022
Merged

UI : New Data profiler Layout. #3184

merged 9 commits into from Mar 6, 2022

Conversation

Sachin-chaurasiya
Copy link
Member

@Sachin-chaurasiya Sachin-chaurasiya commented Mar 6, 2022 •
edited

Describe your changes :

I worked on the new data profiler layout. for more details see #1311

Type of change :

  • Improvement
  • New feature

Frontend Preview (Screenshots) :

image

image

Checklist:

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my own.
  • I have tagged my reviewers below.
  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

@shahsank3t, @darth-coder00

@Sachin-chaurasiya Sachin-chaurasiya self-assigned this Mar 6, 2022
@Sachin-chaurasiya Sachin-chaurasiya marked this pull request as draft March 6, 2022 09:23
@Sachin-chaurasiya Sachin-chaurasiya added enhancement New feature or request new feature UI UI specific issues labels Mar 6, 2022
@Sachin-chaurasiya Sachin-chaurasiya added this to In progress in Release 0.9.0 via automation Mar 6, 2022
@Sachin-chaurasiya Sachin-chaurasiya marked this pull request as ready for review March 6, 2022 14:24
ShaileshParmar11
ShaileshParmar11 requested changes Mar 6, 2022
View reviewed changes
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one comment. other that that LGTM

ShaileshParmar11
ShaileshParmar11 approved these changes Mar 6, 2022
View reviewed changes
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!!

darth-coder00
darth-coder00 approved these changes Mar 6, 2022
View reviewed changes
Copy link
Contributor

@darth-coder00 darth-coder00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarcloud
Copy link

sonarcloud bot commented Mar 6, 2022

[catalog] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Sachin-chaurasiya Sachin-chaurasiya merged commit 40b64d2 into main Mar 6, 2022
Release 0.9.0 automation moved this from In progress to Done Mar 6, 2022
@Sachin-chaurasiya Sachin-chaurasiya deleted the table-profiler branch March 6, 2022 16:46
@Sachin-chaurasiya Sachin-chaurasiya mentioned this pull request Mar 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@darth-coder00 darth-coder00 darth-coder00 approved these changes

@shahsank3t shahsank3t Awaiting requested review from shahsank3t

Assignees

@Sachin-chaurasiya Sachin-chaurasiya

Labels
enhancement New feature or request new feature UI UI specific issues
Projects
No open projects
Release 0.9.0
Done
Milestone
Milestone 5 - 0.9.0 Release
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Sachin-chaurasiya @ShaileshParmar11 @darth-coder00