Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3150 - Missing count & value length tests #3193

Merged
merged 19 commits into from Mar 7, 2022
Merged

Fix #3150 - Missing count & value length tests #3193

merged 19 commits into from Mar 7, 2022

Conversation

pmbrull
Copy link
Collaborator

@pmbrull pmbrull commented Mar 6, 2022 •
edited

Describe your changes :

This PR fixes #3150

OBS: lets merge it after #3192, I was using some changes from that branch as well here.

We are adding the validations for columnValuesMissingCountToBeEqual and columnValueLengthsToBeBetween + prepared a small utility method to easily run metrics on a single column to be used on validations.

Also, one test was running ok in a PR but failed on main, we might need to look into that. I am fixing it here.

Thanks

Type of change :

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Frontend Preview (Screenshots) :

For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

Checklist:

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my own.
  • I have tagged my reviewers below.
  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

@pmbrull pmbrull requested a review from harshach March 6, 2022 15:58
@github-actions
Copy link

github-actions bot commented Mar 6, 2022

The Python checkstyle failed.

Please run make py_format in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@pmbrull pmbrull mentioned this pull request Mar 6, 2022
Merged
8 tasks
@sonarcloud
Copy link

sonarcloud bot commented Mar 7, 2022

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@pmbrull pmbrull merged commit 2444b88 into open-metadata:main Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshach harshach harshach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing count & value length tests
2 participants
@pmbrull @harshach