Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: issue-3199 Data Quality - Missing values #3209

Merged
merged 1 commit into from Mar 7, 2022
Merged

Fix: issue-3199 Data Quality - Missing values #3209

merged 1 commit into from Mar 7, 2022

Conversation

ShaileshParmar11
Copy link
Contributor

Describe your changes :

I worked on the fixing data quality tab issue where config data is not visible.
Closes #3199

Type of change :

  • Bug fix

Frontend Preview (Screenshots) :

image

Checklist:

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my own.
  • I have tagged my reviewers below.
  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

Frontend: @shahsank3t, @darth-coder00, @Sachin-chaurasiya

darth-coder00
darth-coder00 approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@darth-coder00 darth-coder00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarcloud
Copy link

sonarcloud bot commented Mar 7, 2022

[catalog] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Sachin-chaurasiya Sachin-chaurasiya merged commit b569852 into open-metadata:main Mar 7, 2022
@ShaileshParmar11 ShaileshParmar11 deleted the config-issue branch March 7, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmbrull pmbrull pmbrull approved these changes

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya approved these changes

@darth-coder00 darth-coder00 darth-coder00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data Quality - Missing values
4 participants
@ShaileshParmar11 @pmbrull @Sachin-chaurasiya @darth-coder00