Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: issue-2789 Unable to expand Tier1,Tier2 and Tier 3 description on breadcrumb #3212

Merged
merged 2 commits into from Mar 7, 2022
Merged

Fix: issue-2789 Unable to expand Tier1,Tier2 and Tier 3 description on breadcrumb #3212

merged 2 commits into from Mar 7, 2022

Conversation

ShaileshParmar11
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 commented Mar 7, 2022 •
edited

Closes #2789
Closes #3214

Describe your changes :

  • I work on issue-2789 Unable to expand Tier1,Tier2 and Tier 3 description on breadcrumb
  • Fixed issue 3214 Data Quality - Page refreshing after hitting enter on value textbox

Type of change :

  • Bug fix

Frontend Preview (Screenshots) :

Issue: 2789
image
image

issue: 3214

Screen.Recording.2022-03-07.at.4.07.49.PM.mov

Checklist:

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my own.
  • I have tagged my reviewers below.
  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

Frontend: @shahsank3t, @darth-coder00, @Sachin-chaurasiya

darth-coder00
darth-coder00 approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@darth-coder00 darth-coder00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarcloud
Copy link

sonarcloud bot commented Mar 7, 2022

[catalog] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Sachin-chaurasiya Sachin-chaurasiya merged commit 8d9951a into open-metadata:main Mar 7, 2022
@ShaileshParmar11 ShaileshParmar11 deleted the issue-2789 branch March 14, 2022 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya approved these changes

@darth-coder00 darth-coder00 darth-coder00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ShaileshParmar11 @Sachin-chaurasiya @darth-coder00