Fix #3217 - Test case props should be unique #3220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Schema Change Detected. Needs ingestion-core version bump Please run |
pmbrull
commented
Mar 7, 2022
| test_case = ColumnTestCase.parse_obj(obj) | ||
|
|
||
| # TODO: we should parse this properly | ||
| # assert isinstance(test_case.config, ColumnValuesToBeNotNull) |
|
[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed! |
|
[catalog] Kudos, SonarCloud Quality Gate passed!
|
|
I'll merge this in to continue with the testing. Let me know if there's anything we'd need to change here |
| "value": { | ||
| "description": "Expected number of columns to equal to a {value}", | ||
| "columnCount": { | ||
| "description": "Expected number of columns to equal to a {value}", |
There was a problem hiding this comment.
Suggested change
| "description": "Expected number of columns to equal to a {value}", | |
| "description": "Expected number of columns to equal to a {columnCount}", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes :
This PR fixes #3217
When parsing JSONs into pydantic classes we need the
configdict to be unique, otherwise pydantic messes up and does not pick the proper class. In this PR I am updating some names of properties to offer the unicity to the parser, but we will need to maybe rethink a bit the defs.We will still need to fix the
columnValuesToBeUniquevs.columnValuesToBeNotNull. As config is empty in these cases, we cannot guarantee that the proper class gets parsed. cc @harshach I'll open a new issue for them.cc @Sachin-chaurasiya @ShaileshParmar11, please review the updated JSONs in case we need to make some naming changes in the UI.
Thanks,
Type of change :
Frontend Preview (Screenshots) :
For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.
Checklist:
Reviewers