Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-3234: Rename default in role_entity to defaultRole #3235

Merged
merged 3 commits into from Mar 8, 2022

Conversation

harshach
Copy link
Collaborator

@harshach harshach commented Mar 7, 2022

Describe your changes :

see #3234

Type of change :

  • Improvement

Frontend Preview (Screenshots) :

For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

Checklist:

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my own.
  • I have tagged my reviewers below.
  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

@harshach harshach requested a review from mithmatt March 7, 2022 22:20
@github-actions
Copy link

github-actions bot commented Mar 7, 2022

Schema Change Detected. Needs ingestion-core version bump

Please run make core_bump_version_dev in the project's root and commit the changes to _version.py in this PR. Please ignore if this has been handled already.

@mithmatt
Copy link
Collaborator

mithmatt commented Mar 8, 2022

@harshach This parameter is also used in UI codebase, we need to change that too.
Besides that these changes look good from backend

@harshach
Copy link
Collaborator Author

harshach commented Mar 8, 2022

@Sachin-chaurasiya check if we need to make any changes on the UI side

@sonarcloud
Copy link

sonarcloud bot commented Mar 8, 2022

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Sachin-chaurasiya
Copy link
Member

@Sachin-chaurasiya check if we need to make any changes on the UI side

@harshach, Changes for UI is done.

@sonarcloud
Copy link

sonarcloud bot commented Mar 8, 2022

[catalog] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

89.7% 89.7% Coverage
12.8% 12.8% Duplication

@Sachin-chaurasiya Sachin-chaurasiya merged commit b35d111 into main Mar 8, 2022
@Sachin-chaurasiya Sachin-chaurasiya deleted the issue-3234 branch March 8, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants