Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cherry-pick(ui): teams & azure auth fixes #6520

Merged
merged 3 commits into from
Aug 2, 2022
Merged

cherry-pick(ui): teams & azure auth fixes #6520

merged 3 commits into from
Aug 2, 2022

Conversation

chirag-madlani
Copy link
Collaborator

@chirag-madlani chirag-madlani commented Aug 2, 2022 •
edited by akash-jain-10

Describe your changes :

Cherry-picked #6503 #6506 #6516

Type of change :

  • Bug fix
  • Improvement
  • New feature
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation

Frontend Preview (Screenshots) :

For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

Checklist:

  • I have read the CONTRIBUTING document.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

aniketkatkar97 and others added 3 commits August 2, 2022 20:33
@aniketkatkar97 @chirag-madlani
Teams search by query response size increased. (#6503)
3068f2c 
(cherry picked from commit 6175b82)
@chirag-madlani
fix(ui): for use signin we should try fallback popup login (#6506)
aeb4d6b 
* fix(ui): for use signin we should try fallback popup login

* fix authState for signIn page

(cherry picked from commit 6e8da06)
@aniketkatkar97 @chirag-madlani
Fix(Ui): Fixed the teams search irrelevant suggestions issue (#6516)
4c7440e 
* Fixed the issue where teams suggestions when searched were not showing relevant results

* Fixed isJoinable param issue

(cherry picked from commit 13eabfe)
@chirag-madlani chirag-madlani temporarily deployed to cypress August 2, 2022 16:18 Inactive
@chirag-madlani chirag-madlani temporarily deployed to cypress August 2, 2022 16:18 Inactive
@github-actions
Copy link

github-actions bot commented Aug 2, 2022

Schema Change Detected. Needs ingestion-core version bump

Please run make core_bump_version_dev in the project's root and commit the changes to _version.py in this PR. Please ignore if this has been handled already.

@chirag-madlani chirag-madlani reopened this Aug 2, 2022
@chirag-madlani chirag-madlani changed the base branch from main to 0.11.4 August 2, 2022 16:19
@chirag-madlani chirag-madlani temporarily deployed to cypress August 2, 2022 16:20 Inactive
@chirag-madlani chirag-madlani temporarily deployed to cypress August 2, 2022 16:20 Inactive
@sonarcloud
Copy link

sonarcloud bot commented Aug 2, 2022

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

30.4% 30.4% Coverage
0.0% 0.0% Duplication

@akash-jain-10 akash-jain-10 merged commit 7a65b80 into 0.11.4 Aug 2, 2022
@akash-jain-10 akash-jain-10 deleted the silent-fix branch August 2, 2022 16:40
@sonarcloud
Copy link

sonarcloud bot commented Aug 2, 2022

[OpenMetadata-catalog] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug B 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 47 Code Smells

66.9% 66.9% Coverage
5.1% 5.1% Duplication

@chirag-madlani chirag-madlani mentioned this pull request Aug 3, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chirag-madlani @akash-jain-10 @aniketkatkar97