Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Update flags from AuthProvider only #6566

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Conversation

chirag-madlani
Copy link
Collaborator

Describe your changes :

I worked on the fixing azure login issue
User get stuck when they try to resume their work on OMD after an hour

Type of change :

  • Bug fix

Frontend Preview (Screenshots) :

For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

Checklist:

  • I have read the CONTRIBUTING document.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

Frontend: @open-metadata/ui

@chirag-madlani chirag-madlani temporarily deployed to cypress August 4, 2022 09:16 Inactive
@chirag-madlani chirag-madlani temporarily deployed to cypress August 4, 2022 09:16 Inactive
@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2022

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2022

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

9.1% 9.1% Coverage
0.0% 0.0% Duplication

@cypress
Copy link

cypress bot commented Aug 4, 2022



Test summary

55 0 3 0


Run details

Project openmetadata
Status Passed
Commit 4834d3d
Started Aug 4, 2022 9:33 AM
Ended Aug 4, 2022 9:47 AM
Duration 13:45 💡
OS Linux Ubuntu - 20.04
Browser Chrome 103

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2022

[OpenMetadata-catalog] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ShaileshParmar11 ShaileshParmar11 merged commit c6d35f7 into main Aug 4, 2022
@ShaileshParmar11 ShaileshParmar11 deleted the azure-fix branch August 4, 2022 11:59
chirag-madlani added a commit that referenced this pull request Aug 4, 2022
chirag-madlani added a commit that referenced this pull request Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants