Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] - Prep Demo Connector #7984

Closed
wants to merge 1 commit into from

Conversation

pmbrull
Copy link
Collaborator

@pmbrull pmbrull commented Oct 6, 2022

Describe your changes :

This is a sample PR showcasing specific steps that need to be followed to create a new connector in OpenMetadata.

Looking forward to your contributions :)

Type of change :

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Frontend Preview (Screenshots) :

For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

Checklist:

  • I have read the CONTRIBUTING document.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

@pmbrull pmbrull requested a review from a team as a code owner October 6, 2022 13:39
@pmbrull pmbrull temporarily deployed to cypress October 6, 2022 13:39 Inactive
@pmbrull pmbrull temporarily deployed to cypress October 6, 2022 13:39 Inactive
@pmbrull pmbrull temporarily deployed to cypress October 6, 2022 13:39 Inactive
@pmbrull pmbrull temporarily deployed to cypress October 6, 2022 13:39 Inactive
@github-actions
Copy link

github-actions bot commented Oct 6, 2022

The Python checkstyle failed.

Please run make py_format in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@cypress
Copy link

cypress bot commented Oct 6, 2022



Test summary

139 4 3 0


Run details

Project openmetadata
Status Failed
Commit b0a14cc
Started Oct 6, 2022 2:00 PM
Ended Oct 6, 2022 2:29 PM
Duration 28:46 💡
OS Linux Ubuntu - 20.04
Browser Chrome 106

View run in Cypress Dashboard ➡️


Failures

Teams.spec.js Failed
1 Teams flow should work properly > Update description and display name for created team
2 Teams flow should work properly > Permanently deleting soft deleted team should work properly
3 Teams flow should work properly > Permanently deleting a team without soft deleting should work properly
Bots.spec.js Failed
1 Bots Page should work properly > Update token expiration for 90 days

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant