Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update as per feedbacks #151

Merged
merged 2 commits into from
Jul 2, 2024
Merged

update as per feedbacks #151

merged 2 commits into from
Jul 2, 2024

Conversation

sweta1308
Copy link
Contributor

@sweta1308 sweta1308 commented Jul 2, 2024 •
edited
Loading

Update components as per feedbacks.

  1. Reduced the size of buttons.
image 2. Bring "All Connectors" to center and made the Saphana logo wider. image 3. Brought the dots in the top. image 4. Reduced the gap between cards and add padding inside cards. image 5. Reduced the size of netlify logo and add gap between logo and commuity contents. image

Sachin-chaurasiya
Sachin-chaurasiya reviewed Jul 2, 2024
View reviewed changes
src/components/KeyDataAssets/KeyDataAssets.tsx Outdated
@@ -58,7 +58,7 @@ const KeyDataAssets = () => {
alt="Key Data Assets"
width={1000}
height={600}
loading="lazy"
priority={openTab === currentUsecase.imgSrc}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sweta1308, why is this condition for image priority? and what will be the value of currentUsecase.imgSrc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because of this feedback.
image
I saw that with this priority, maybe this issue can be handle.
And currentUsecase.imgSrc is the image Src. Sorry, this is my mistake, we have to add the name here, instead of imgSrc.
As in local, I am not able to see much difference.

@Sachin-chaurasiya Sachin-chaurasiya merged commit b7e8b98 into open-metadata:development Jul 2, 2024
chirag-madlani added a commit that referenced this pull request Jul 9, 2024
@Sachin-chaurasiya @sweta1308 @chirag-madlani
Revamp Home Page (#126)
77891c2 
* Revamp navbar component (#125)

* add development page

* add navbar component

* add github logo

* add collate logo

* update transition duration

* Add Header Component (#129)

* add client logos

* add assets for header

* add client component

* add header component

* add header in development page

* add clients list

* add styles for slider images

* reduced the opacity of the client logo

* update css

* Add Achievement component (#130)

* add bg images

* add card icons

* add achievement component

* add breakpoint for carousel

* add list of achievements

* add achievements in development page

* Made Style Fixes (#131)

* add illustrations

* update achievement component

* add services component

* add list of services

* add services in development page

* add illustrations for key data assets

* add key data assets component

* add constant for key data assets

* add key data assets component in development page

* Made Fixes in navbar and key data assets (#134)

* remove assets

* add components for icons

* update active tab colors

* update styling for mobile view

* update the icons

* Add Integrations component (#135)

* remove assets

* add components for icons

* update active tab colors

* update styling for mobile view

* update the icons

* add integrations component

* Add Try openmetadata component (#136)

* remove assets

* add components for icons

* update active tab colors

* update styling for mobile view

* update the icons

* add integrations component

* add try openmetadata component

* add new tag in card

* update new tag

---------

Co-authored-by: Sachin Chaurasiya <sachinchaurasiyachotey87@gmail.com>

* Add About openmetadata component (#137)

* remove assets

* add components for icons

* update active tab colors

* update styling for mobile view

* update the icons

* add integrations component

* add try openmetadata component

* add new tag in card

* update new tag

* add blogs component

* update heading text size

---------

Co-authored-by: Sachin Chaurasiya <sachinchaurasiyachotey87@gmail.com>

* Add Footer Component (#139)

* remove assets

* add components for icons

* update active tab colors

* update styling for mobile view

* update the icons

* add integrations component

* add try openmetadata component

* add new tag in card

* update new tag

* add blogs component

* update heading text size

* update client logos alignment

* add testimonial component

* update logo width

* update footer

* Add Testimonial component (#138)

* remove assets

* add components for icons

* update active tab colors

* update styling for mobile view

* update the icons

* add integrations component

* add try openmetadata component

* add new tag in card

* update new tag

* add blogs component

* update heading text size

* update client logos alignment

* add testimonial component

* update logo width

* Made fixes in layout and alignment (#140)

* made fixes in layout and alignment

* add navbar strip component

* remove shadow bg

* add custom class for max width and shadow bg

* Update as per feedbacks (#141)

* update as per feedbacks

* update hover effect

* Update lazy loading for images and fix header link targets

* Update NavbarStrip component layout and alignment

* Add fixes for integration bg for active tab and testimonial (#142)

* add fixes for integration bg for active tab and testimonial

* add fixes as per feedbacks

* add fixes as per feedbacks

* add image loading (#143)

* add loading eager to images (#144)

* Update as per client feedbacks (#145)

* update as per client feedbacks

* update scroll issue

* update the use cases header

* update the Get Started url

* remove gradient class

* update function name

* close the menu when button clicked

* Updated as per feedbacks (#148)

* updated as per feedbacks

* update slider

* update the carousel to be in continuous loop

* update the get started url and fix the scroll (#149)

* updated the font sizes as per figma (#150)

* updated the font sizes as per figma

* update font size

* update padding

* update as per feedbacks (#151)

* update as per feedbacks

* update image props

* update layouting (#153)

* add letter spacings and fix layouting (#154)

* Update padding for try openmetadata (#155)

* update padding for try openmetadata

* update line height

* chore: Update Testimonials component to use `beforeChange` instead of `afterChange` for slide activation

* updated svgs into components (#156)

* Add mobile design (#152)

* add mobile-design for navbar

* update mobile design for navbar

* add mobile view for header

* update strip responsive

* update navbar and header responsive design

* add responsive design for components

* update mobile responsive design

* add dropdown in integrations component for mobile biew

* update responsive design

* update responsive design

* update responsive design

* update header and testimonial boxes (#157)

* add fixes (#158)

* fix: Update URLs in NavbarDev component and Achievement constants

* chore: Update AboutOpenMetadata component layout

* chore: Remove unused components and update page layout

* remove autoplay from testimonials (#159)

* update kpi data (#160)

---------

Co-authored-by: Sweta Agarwalla <105535990+sweta1308@users.noreply.github.com>
Co-authored-by: Sweta Agarwalla <swetaagarwalla13@gmail.com>
Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sweta1308 @Sachin-chaurasiya