Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change enum IconVariable and Awscli installation via APT - Update getting-started.md #458

Merged
merged 7 commits into from Oct 6, 2023

Conversation

StackNeverFlow
Copy link
Contributor

@StackNeverFlow StackNeverFlow commented Oct 3, 2023

Change enum IconVariable and Awscli installation via APT - Update getting-started.md

Description

This pull requets updates the docs/getting-started.md file, in which the documentation for "deployment" lifes in.

Changes

  • Updated the link for ICON weather variables from enum IconVariable to IconVariables in the getting-started.md file.
  • Added installation command for the awscli, via sudo apt-get install awscli

Context

The current link was leading to the wrong/ old file, causing confusion for users trying to access the list of ICON weather variables. This change ensures that the link accurately directs users to the correct location.
The Aws S3 Bucket Sync only works, if the awscli is installed.

@StackNeverFlow StackNeverFlow changed the title Change "enum IconVariable" Link - Update getting-started.md Change enum IconVariable and awscli installation via APT - Update getting-started.md Oct 3, 2023
@StackNeverFlow StackNeverFlow changed the title Change enum IconVariable and awscli installation via APT - Update getting-started.md Change enum IconVariable and Awscli installation via APT - Update getting-started.md Oct 3, 2023
@patrick-zippenfenig
Copy link
Member

Thanks for the update and fixing the broken link. Can you point the link to

enum IconSurfaceVariable: String, CaseIterable, GenericVariableMixable {
? This is a bit easier to understand

@patrick-zippenfenig patrick-zippenfenig merged commit d0c3685 into open-meteo:main Oct 6, 2023
1 of 2 checks passed
@patrick-zippenfenig
Copy link
Member

Thanks!

@StackNeverFlow StackNeverFlow deleted the patch-1 branch October 6, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants