Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MFA Restructure & Environment Bug Fixes #121

Merged
merged 3 commits into from
Jan 29, 2024

Conversation

Merakist
Copy link
Collaborator

@Merakist Merakist commented Jan 26, 2024

✨ Description

  • Address fs2 preprocessing exception due to mismatched package versions
  • Refactor MFA file structure into /pretrained and modify control logic in fetching and managing MFA files

🚧 Related Issues

👨‍💻 Changes Proposed

  • Modifying directories in preprocessors/ljspeech.py to change the saving directory for MFA files from the root folder to /pretrained to comply with file management convention for Amphion system; additionally, link lexicon directory to provided lexicon file to avoid redundant files.
  • Rewrite prepare_mfa.sh and modify run.sh for a more robust logic in fetching and managing MFA files; removing the redundant section for downloading LJSpeech lexicon.
  • Modifying env.sh to specify librosa version to 0.9.1 and vector-quantize-pytorch to 1.12.5

🧑‍🤝‍🧑 Who Can Review?

@lmxue @RMSnow

🛠 TODO

Potential Consideration: A few issues seem to arise from preparing environments, one consideration could be to freeze versions for certain packages for better stability @RMSnow.

✅ Checklist

  • Code has been reviewed
  • Code complies with the project's code standards and best practices
  • Code has passed all tests
  • Code does not affect the normal use of existing features
  • Code has been commented properly
  • Documentation has been updated (if applicable)
  • Demo/checkpoint has been attached (if applicable)

Copy link
Collaborator

@RMSnow RMSnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

env.sh Show resolved Hide resolved
@Merakist Merakist requested a review from RMSnow January 28, 2024 08:17
Copy link
Collaborator

@lmxue lmxue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested the MFA processing pipeline with the updated code?

@Merakist
Copy link
Collaborator Author

Have you tested the MFA processing pipeline with the updated code?

Yes, the modified MFA processing pipeline ran without errors occurring.

@Merakist Merakist requested a review from lmxue January 29, 2024 01:08
Copy link
Collaborator

@lmxue lmxue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution.

@RMSnow RMSnow merged commit 25a4bd1 into open-mmlab:main Jan 29, 2024
1 check failed
ArkhamImp pushed a commit to ArkhamImp/Amphion that referenced this pull request Apr 17, 2024
Specify the versions of librosa and diffsptk. Standadize MFA file structure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants