Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement VitsSVC resume training / finetune feature #95

Merged
merged 10 commits into from
Jan 22, 2024

Conversation

viewfinder-annn
Copy link
Collaborator

@viewfinder-annn viewfinder-annn commented Jan 9, 2024

✨ Description:

This PR addresses bugs in VitsSVC module, mainly related to:

  1. implement resume training / finetune feature
  2. fix bug for multiple acoustic content training

🚧 Related Issues:

#91

πŸ‘¨β€πŸ’» Changes Proposed:

  • Fix bug in models/svc/vits/vits.py, removed useless content_vec feature dependency.
  • Refractor VitsSVCTrainer to detach from TTSTrainer

πŸ§‘β€πŸ€β€πŸ§‘ Who can review?

@RMSnow @lmxue

πŸ›  TODO

  • Further clean up config
  • Refractor VitsSVCTrainer to detach from TTSTrainer

βœ… Checklist:

  • Code has been reviewed
  • Code complies with the project's code standards and best practices
  • Code has passed all tests
  • Code does not affect the normal use of existing features
  • Code has been commented properly
  • Documentation has been updated (if applicable)

Copy link
Collaborator

@RMSnow RMSnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Implement VitsSVCTrainer from the SVC's trainer as the base instead of the TTS ones
  2. Refine the config json files. Move some common setting to a config/svc.json, and make the exp_config.json as user-friendly as possible

@viewfinder-annn
Copy link
Collaborator Author

Just fixed problem 1, now this PR doesn't affect tasks other than SVC.

@viewfinder-annn
Copy link
Collaborator Author

Now the default training data config is the same across DiffWaveNet and VitsSVC. The exp_config.json is now user-friendly with fewer exposed options. I'll refractor SVC preprocess to svc.json in another PR soon.

models/svc/vits/vits.py Show resolved Hide resolved
Copy link
Collaborator

@lmxue lmxue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@RMSnow RMSnow self-requested a review January 22, 2024 04:22
@RMSnow RMSnow merged commit eafa50d into open-mmlab:main Jan 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants