Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check & Update PR Template #96

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Check & Update PR Template #96

merged 2 commits into from
Jan 9, 2024

Conversation

HarryHe11
Copy link
Collaborator

✨ Description

Updated the PR template: added section marks and fixed typos.

🚧 Related Issues

No related issues.

👨‍💻 Changes Proposed

  • added section marks
  • fixed some typos

🧑‍🤝‍🧑 Who Can Review?

@RMSnow

🛠 TODO

No TODO.

✅ Checklist

  • Code has been reviewed
  • Code complies with the project's code standards and best practices
  • Code has passed all tests
  • Code does not affect the normal use of existing features
  • Code has been commented properly
  • Documentation has been updated (if applicable)
  • Demo/checkpoint has been attached (if applicable)

@HarryHe11 HarryHe11 changed the title Check pr Check & Update PR Template Jan 9, 2024
@HarryHe11 HarryHe11 requested a review from RMSnow January 9, 2024 09:22
RMSnow
RMSnow approved these changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@RMSnow RMSnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@RMSnow RMSnow merged commit 6101b4a into open-mmlab:main Jan 9, 2024
1 check passed
@HarryHe11 HarryHe11 deleted the check-pr branch January 10, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RMSnow RMSnow RMSnow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HarryHe11 @RMSnow