Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra dependencies to extra_require #133

Merged
merged 2 commits into from
Jun 16, 2022

Conversation

zhouzaida
Copy link
Member

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add extra dependencies to extra_require.

Modification

  • Add requirements.txt.
  • Update setup.py.

BC-breaking (Optional)

No

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@zhouzaida zhouzaida requested a review from ice-tong June 16, 2022 08:12
@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #133 (3de8b9c) into main (77f5866) will not change coverage.
The diff coverage is n/a.

❗ Current head 3de8b9c differs from pull request most recent head 0738c33. Consider uploading reports for the commit 0738c33 to get more accurate results

@@           Coverage Diff           @@
##             main     #133   +/-   ##
=======================================
  Coverage   32.77%   32.77%           
=======================================
  Files          22       22           
  Lines        1620     1620           
  Branches      371      371           
=======================================
  Hits          531      531           
  Misses       1045     1045           
  Partials       44       44           
Flag Coverage Δ
unittests 32.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77f5866...0738c33. Read the comment docs.

setup.py Show resolved Hide resolved
Copy link
Collaborator

@ice-tong ice-tong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouzaida zhouzaida merged commit 7421125 into open-mmlab:main Jun 16, 2022
@zhouzaida zhouzaida deleted the improve-setup branch June 16, 2022 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants