New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] refactor mim uninstall #135
[Refactor] refactor mim uninstall #135
Conversation
Codecov Report
@@ Coverage Diff @@
## main #135 +/- ##
==========================================
+ Coverage 53.95% 54.44% +0.49%
==========================================
Files 23 23
Lines 1544 1552 +8
Branches 329 331 +2
==========================================
+ Hits 833 845 +12
+ Misses 585 582 -3
+ Partials 126 125 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Please add unit tests for uninstall command. |
…invoke pip uninstall
208facf
to
0a19ffb
Compare
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
…into yancong-refactor-uninstall
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Refactor
mim uninstall
in order to use the same method aspip uninstall
.Modification
commands/uninstall.py
-r / --requirements
option.package
touninstall_args
to uninstall multiple packages at the same time.mim uninstall
topip uninstall
.BC-breaking (Optional)
Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist