Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beautiful progressbar #139

Merged
merged 2 commits into from Jun 24, 2022

Conversation

zhouzaida
Copy link
Member

@zhouzaida zhouzaida commented Jun 23, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Refer to https://github.com/pypa/pip/blob/main/src/pip/_internal/cli/progress_bars.py

image

Modification

Added rich_progress_bar helper function.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@zhouzaida zhouzaida requested a review from ice-tong June 23, 2022 14:00
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #139 (06ec624) into main (d2df7c8) will increase coverage by 0.36%.
The diff coverage is 84.21%.

❗ Current head 06ec624 differs from pull request most recent head 91bc39a. Consider uploading reports for the commit 91bc39a to get more accurate results

@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
+ Coverage   53.59%   53.95%   +0.36%     
==========================================
  Files          22       23       +1     
  Lines        1532     1544      +12     
  Branches      328      329       +1     
==========================================
+ Hits          821      833      +12     
  Misses        585      585              
  Partials      126      126              
Flag Coverage Δ
unittests 53.95% <84.21%> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mim/utils/utils.py 67.88% <57.14%> (ø)
mim/utils/__init__.py 100.00% <100.00%> (ø)
mim/utils/progress_bars.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2df7c8...91bc39a. Read the comment docs.

@zhouzaida zhouzaida merged commit 90d97cd into open-mmlab:main Jun 24, 2022
@zhouzaida zhouzaida deleted the add-beautiful-progressbar branch June 24, 2022 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant