Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Change resources directory to .mim #68

Merged
merged 10 commits into from
Jul 24, 2021

Conversation

zhouzaida
Copy link
Member

@zhouzaida zhouzaida commented Jul 24, 2021

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Change the resources directory to package/.mim rather than package/

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

mim/commands/gridsearch.py Outdated Show resolved Hide resolved
mim/commands/search.py Outdated Show resolved Hide resolved
@zhouzaida zhouzaida added the wip label Jul 24, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2021

Codecov Report

Merging #68 (560e7f8) into main (0bd1f4d) will decrease coverage by 0.13%.
The diff coverage is 74.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
- Coverage   64.08%   63.95%   -0.14%     
==========================================
  Files          21       21              
  Lines        1548     1559      +11     
  Branches      341      346       +5     
==========================================
+ Hits          992      997       +5     
+ Misses        429      428       -1     
- Partials      127      134       +7     
Flag Coverage Δ
unittests 63.95% <74.62%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mim/commands/gridsearch.py 53.61% <33.33%> (-0.66%) ⬇️
mim/commands/train.py 45.88% <33.33%> (-1.11%) ⬇️
mim/commands/search.py 78.91% <60.00%> (-0.49%) ⬇️
mim/commands/run.py 63.51% <66.66%> (-0.26%) ⬇️
mim/commands/test.py 44.32% <66.66%> (+0.11%) ⬆️
mim/commands/download.py 88.46% <80.00%> (-1.74%) ⬇️
mim/commands/install.py 68.37% <89.47%> (-1.50%) ⬇️
mim/commands/list.py 82.14% <100.00%> (+7.94%) ⬆️
mim/utils/utils.py 78.94% <0.00%> (+2.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bd1f4d...560e7f8. Read the comment docs.

@zhouzaida zhouzaida removed the wip label Jul 24, 2021
@zhouzaida
Copy link
Member Author

I am testing again in mmpose

@ZwwWayne ZwwWayne merged commit acab45a into open-mmlab:main Jul 24, 2021
@zhouzaida zhouzaida deleted the change-resources-directory branch July 24, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants