[Fix] Fix a bug in BaseDataset when data_prefix is None (#314)

* fix a bug when data_prefix is None * update changelog
open-mmlab · Nov 6, 2020 · 17485aa · 17485aa
1 parent bdb3ebe
commit 17485aa
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 2 deletions.
diff --git a/docs/changelog.md b/docs/changelog.md
@@ -1,5 +1,18 @@
 ## Changelog
 
+###v 0.9.0 (master)
+
+**Highlights**
+
+**New Features**
+
+**Improvements**
+
+**Bug Fixes**
+- Fix a bug in BaseDataset when `data_prefix` is None ([#314](https://github.com/open-mmlab/mmaction2/pull/314))
+
+**ModelZoo**
+
 ### v0.8.0 (31/10/2020)
 
 **Highlights**

diff --git a/mmaction/datasets/base.py b/mmaction/datasets/base.py
@@ -67,8 +67,9 @@ def __init__(self,
         super().__init__()
 
         self.ann_file = ann_file
-        self.data_prefix = osp.realpath(data_prefix) if osp.isdir(
-            data_prefix) else data_prefix
+        self.data_prefix = osp.realpath(
+            data_prefix) if data_prefix is not None and osp.isdir(
+                data_prefix) else data_prefix
         self.test_mode = test_mode
         self.multi_class = multi_class
         self.num_classes = num_classes

diff --git a/tests/test_data/test_dataset.py b/tests/test_data/test_dataset.py
@@ -265,6 +265,10 @@ def test_dataset_realpath(self):
                                   's3://good')
         assert dataset.data_prefix == 's3://good'
 
+        dataset = RawframeDataset(self.frame_ann_file, self.frame_pipeline)
+        assert dataset.data_prefix is None
+        assert dataset.video_infos[0]['frame_dir'] == 'test_imgs'
+
     def test_video_dataset(self):
         video_dataset = VideoDataset(
             self.video_ann_file,