Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are the commands to preprocess Kinetics dataset in the Preparing Kinetics readme which gives videos of resolution 340x256 different from the resolution used in configs? #482

Closed
yxchng opened this issue Dec 23, 2020 · 5 comments · Fixed by #538
Assignees
Labels
documentation Improvements or additions to documentation faq candidate

Comments

@yxchng
Copy link

yxchng commented Dec 23, 2020

https://github.com/open-mmlab/mmaction2/tree/master/configs/recognition/slowfast
https://github.com/open-mmlab/mmaction2/tree/master/configs/recognition/r2plus1d

For example, in these configs, the model use short side 320 or short side 256.

Why don't extract_rgb_frames.sh, extract_rgb_frames_opencv.sh, and extract_frames.sh follow that and gives short side 320 or short side 256?

@innerlee
Copy link
Contributor

You can modify the scripts to get preferred resolution. See the docs

image

The default setting occupies smaller disk space, and was historically used by UCF101.

@innerlee innerlee added the question Further information is requested label Dec 24, 2020
@yxchng
Copy link
Author

yxchng commented Dec 24, 2020

@innerlee yes, i know that i can modify the commands but my question is why is the default setting 340x256 when there is no model that is using that? why not change the default to something that aligns with the is used by the models?

If I have not read the configs, I would not know that I am doing the preprocessing wrong.

@innerlee
Copy link
Contributor

The processing is not wrong. Generally speaking, higher resolution is better. There is a benchmark on resolutions in docs.

image

@innerlee innerlee added documentation Improvements or additions to documentation and removed question Further information is requested labels Dec 24, 2020
@innerlee
Copy link
Contributor

@dreamerlin We can add more info on choosing resolutions in the data preparation doc.

@kennymckormick
Copy link
Member

@innerlee yes, i know that i can modify the commands but my question is why is the default setting 340x256 when there is no model that is using that? why not change the default to something that aligns with the is used by the models?

If I have not read the configs, I would not know that I am doing the preprocessing wrong.

That's right, the default setting is 340x256 because of some legacy issues, will raise a PR to switch to shortside 256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation faq candidate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants