Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] support ava-kinetics #2080

Merged
merged 15 commits into from Dec 5, 2022
Merged

Conversation

hukkai
Copy link
Collaborator

@hukkai hukkai commented Nov 22, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily got feedback.
If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduces changes that break the back-compatibility of this repo?
If so, please describe how it breaks the compatibility and how users should modify their codes to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools should be used to fix the potential lint issues.
  2. The modification should be covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation should be modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Base: 76.00% // Head: 76.65% // Increases project coverage by +0.65% 🎉

Coverage data is based on head (6a17dfa) compared to base (a0863e9).
Patch has no changes to coverable lines.

❗ Current head 6a17dfa differs from pull request most recent head 5335506. Consider uploading reports for the commit 5335506 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2080      +/-   ##
===========================================
+ Coverage    76.00%   76.65%   +0.65%     
===========================================
  Files          137      139       +2     
  Lines         9918     9964      +46     
  Branches      1626     1631       +5     
===========================================
+ Hits          7538     7638     +100     
+ Misses        2029     1972      -57     
- Partials       351      354       +3     
Flag Coverage Δ
unittests 76.65% <ø> (+0.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmaction/models/backbones/swin.py 93.06% <0.00%> (-0.22%) ⬇️
mmaction/testing/__init__.py 100.00% <0.00%> (ø)
mmaction/testing/_utils.py 45.56% <0.00%> (ø)
mmaction/models/heads/base.py 80.00% <0.00%> (+2.35%) ⬆️
mmaction/models/recognizers/base.py 64.55% <0.00%> (+3.84%) ⬆️
mmaction/models/backbones/resnet2plus1d.py 100.00% <0.00%> (+4.00%) ⬆️
mmaction/models/backbones/vit_mae.py 95.45% <0.00%> (+4.75%) ⬆️
mmaction/models/recognizers/recognizer2d.py 59.61% <0.00%> (+9.61%) ⬆️
mmaction/utils/gradcam_utils.py 97.72% <0.00%> (+88.53%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

hukkai and others added 6 commits November 30, 2022 00:59
Co-authored-by: cir7 <33249023+cir7@users.noreply.github.com>
Co-authored-by: cir7 <33249023+cir7@users.noreply.github.com>
@hukkai hukkai requested review from cir7 and ly015 December 1, 2022 23:13
@hukkai hukkai assigned ly015 and unassigned Dai-Wenxun Dec 2, 2022
@ly015 ly015 changed the title support ava-kinetics [Feature] support ava-kinetics Dec 5, 2022
@ly015 ly015 merged commit 82d2d17 into open-mmlab:dev-1.x Dec 5, 2022
@hukkai hukkai deleted the ava-kinetics branch December 7, 2022 00:37
ly015 pushed a commit that referenced this pull request Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants