Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge dev-1.x to main #2551

Merged
merged 39 commits into from
Jul 4, 2023
Merged

Merge dev-1.x to main #2551

merged 39 commits into from
Jul 4, 2023

Conversation

cir7
Copy link
Collaborator

@cir7 cir7 commented Jun 19, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily got feedback.
If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduces changes that break the back-compatibility of this repo?
If so, please describe how it breaks the compatibility and how users should modify their codes to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools should be used to fix the potential lint issues.
  2. The modification should be covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation should be modified accordingly, like docstring or example tutorials.

Dai-Wenxun and others added 26 commits April 11, 2023 14:40
* [Fix] Align num_persons among frames and filter frame without det result
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch coverage: 61.77% and project coverage change: -0.72 ⚠️

Comparison is base (07259a2) 76.97% compared to head (100bdbe) 76.25%.

❗ Current head 100bdbe differs from pull request most recent head 56c18a2. Consider uploading reports for the commit 56c18a2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2551      +/-   ##
==========================================
- Coverage   76.97%   76.25%   -0.72%     
==========================================
  Files         159      170      +11     
  Lines       12546    13904    +1358     
  Branches     2099     2375     +276     
==========================================
+ Hits         9657    10603     +946     
- Misses       2386     2732     +346     
- Partials      503      569      +66     
Flag Coverage Δ
unittests 76.25% <61.77%> (-0.72%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmaction/datasets/rawframe_dataset.py 93.33% <0.00%> (-4.40%) ⬇️
mmaction/datasets/transforms/wrappers.py 56.34% <0.00%> (-0.91%) ⬇️
mmaction/datasets/video_dataset.py 89.65% <0.00%> (-6.65%) ⬇️
mmaction/models/localizers/bsn.py 90.90% <ø> (ø)
mmaction/models/recognizers/recognizer3d.py 67.85% <ø> (ø)
mmaction/testing/__init__.py 100.00% <ø> (ø)
mmaction/utils/typing_utils.py 95.00% <ø> (ø)
mmaction/visualization/action_visualizer.py 70.19% <ø> (ø)
...ptimizers/layer_decay_optim_wrapper_constructor.py 17.64% <8.33%> (-2.00%) ⬇️
mmaction/utils/collect_env.py 22.72% <8.33%> (-17.28%) ⬇️
... and 52 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cir7 cir7 merged commit 0e614dd into main Jul 4, 2023
19 of 24 checks passed
@cir7 cir7 added the invalid This doesn't seem right label Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants