Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeCamp2023-545] Support video retrieval dataset MSVD #2622

Merged
merged 16 commits into from
Aug 15, 2023

Conversation

xiaoyi0919
Copy link
Contributor

@xiaoyi0919 xiaoyi0919 commented Aug 2, 2023

支持 MSVD 视频检索数据集

Support MSVD video retrieval dataset in mmaction2, including the original dataset download and processing scripts (the processed data should be located in the data/video_retrieval/msvd directory and conform to the mmaction2 video retrieval task data format, which can refer to the already supported MST-VTT dataset), download and processing scripts can refer to prepare_msrvtt.py and prepare_msrvtt.sh in tools/data/video_retrieval, and need to update the README under tools/data/video_retrieval, mainly including the dataset citation and introduction, the invocation method of download and processing scripts, and the data directory structure tree after processing.

在 mmaction2 中支持 MSVD 视频检索数据集,包括原始数据集下载和处理脚本(经过处理后的数据应位于 data/video_retrieval/msvd 目录下且符合 mmaction2 视频检索任务数据格式,可参考已经支持的 MST-VTT 数据集),下载和处理脚本可参考 tools/data/video_retrieval 下的 prepare_msrvtt.py 和 prepare_msrvtt.sh,并且需要更新 tools/data/video_retrieval 下的 README,主要包括主要包括数据集的引用和简介、下载处理脚本的调用方法和处理完成的数据目录结构树。

@CLAassistant
Copy link

CLAassistant commented Aug 2, 2023

CLA assistant check
All committers have signed the CLA.

@Dai-Wenxun
Copy link
Collaborator

Excellent job! We'll review your code next week, please keep in touch.

@Dai-Wenxun
Copy link
Collaborator

Could you please push the commits to dev-1.x branch?
image

@xiaoyi0919 xiaoyi0919 changed the base branch from main to dev-1.x August 12, 2023 01:42
@Dai-Wenxun Dai-Wenxun changed the title [CodeCamp2023-545]Support video retrieval dataset MSVD [CodeCamp2023-545] Support video retrieval dataset MSVD Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.18% 🎉

Comparison is base (1405434) 75.99% compared to head (32436ed) 76.17%.
Report is 231 commits behind head on dev-1.x.

❗ Current head 32436ed differs from pull request most recent head b989872. Consider uploading reports for the commit b989872 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2622      +/-   ##
===========================================
+ Coverage    75.99%   76.17%   +0.18%     
===========================================
  Files          151      170      +19     
  Lines        11376    13798    +2422     
  Branches      1881     2362     +481     
===========================================
+ Hits          8645    10511    +1866     
- Misses        2298     2719     +421     
- Partials       433      568     +135     
Flag Coverage Δ
unittests 76.17% <ø> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 92 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cir7 cir7 merged commit f701d94 into open-mmlab:dev-1.x Aug 15, 2023
11 of 14 checks passed
@OpenMMLab-Assistant-004

Hi @xiaoyi0919,

We'd like to express our appreciation for your valuable contributions to the mmaction2. Your efforts have significantly aided in enhancing the project's quality.
It is our pleasure to invite you to join our community thorugh Discord_Special Interest Group (SIG) channel. This is a great place to share your experiences, discuss ideas, and connect with other like-minded people. To become a part of the SIG channel, send a message to the moderator, OpenMMLab, briefly introduce yourself and mention your open-source contributions in the #introductions channel. Our team will gladly facilitate your entry. We eagerly await your presence. Please follow this link to join us: ​https://discord.gg/UjgXkPWNqA.

If you're on WeChat, we'd also love for you to join our community there. Just add our assistant using the WeChat ID: openmmlabwx. When sending the friend request, remember to include the remark "mmsig + Github ID".

Thanks again for your awesome contribution, and we're excited to have you as part of our community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants