Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] fix data preparation bug #278

Merged
merged 2 commits into from
Oct 24, 2020
Merged

Conversation

dreamerlin
Copy link
Collaborator

No description provided.

@dreamerlin dreamerlin linked an issue Oct 24, 2020 that may be closed by this pull request
@dreamerlin dreamerlin linked an issue Oct 24, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 24, 2020

Codecov Report

Merging #278 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #278      +/-   ##
==========================================
- Coverage   85.05%   85.01%   -0.04%     
==========================================
  Files          88       88              
  Lines        5994     5994              
  Branches      983      983              
==========================================
- Hits         5098     5096       -2     
- Misses        709      710       +1     
- Partials      187      188       +1     
Flag Coverage Δ
#unittests 85.01% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmaction/core/evaluation/accuracy.py 88.88% <0.00%> (-0.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d974c2c...17bb820. Read the comment docs.

@innerlee
Copy link
Contributor

scripts are too easy to be break. hope someone could add scripts to tests

@innerlee innerlee merged commit 9c71443 into open-mmlab:master Oct 24, 2020
@yuhuixu1993
Copy link

yuhuixu1993 commented Oct 24, 2020

Thanks for your contribution, I merged the updated tools/sthv2. It seems that the problem of sthv2 still exists. @dreamerlin. Do I need to regenerate the raw frames?

@dreamerlin
Copy link
Collaborator Author

dreamerlin commented Oct 24, 2020

Thanks for your contribution, I merged the updated tools/sthv2. It seems that the problem of sthv2 still exists. @dreamerlin. Do I need to regenerate the raw frames?

Actually not. Is It the same problem? I test it and go with no problems. BTW, it seems necessary to add unittest for the dataset preparation : )

@yuhuixu1993
Copy link

@dreamerlin , I have solved it, thanks for your contribution!

@dreamerlin
Copy link
Collaborator Author

dreamerlin commented Oct 24, 2020

@dreamerlin , I have solved it, thanks for your contribution!

Glad to hear that!

@dreamerlin dreamerlin deleted the fix_sth branch November 3, 2020 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems: raw frames filelist of sthv2 Problems with Preparing dataset sthv1
3 participants