Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix#306 #317

Merged
merged 9 commits into from
Nov 6, 2020
Merged

[Fix] Fix#306 #317

merged 9 commits into from
Nov 6, 2020

Conversation

kennymckormick
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #317 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #317      +/-   ##
==========================================
- Coverage   82.35%   82.34%   -0.01%     
==========================================
  Files          95       95              
  Lines        6777     6768       -9     
  Branches     1099     1095       -4     
==========================================
- Hits         5581     5573       -8     
  Misses        987      987              
+ Partials      209      208       -1     
Flag Coverage Δ
unittests 82.32% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmaction/datasets/pipelines/loading.py 86.11% <100.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 693f182...9d8b7f1. Read the comment docs.

@innerlee
Copy link
Contributor

innerlee commented Nov 6, 2020

You can try git rebase later, which produces a cleaner history.

Tests that capture this bug should be added.

@dreamerlin
Copy link
Collaborator

Accordint to #306, u can set another case clip_len=8, frame_interval=8 in pytest : )

@innerlee innerlee merged commit bdb3ebe into open-mmlab:master Nov 6, 2020
@kennymckormick kennymckormick deleted the fix#306 branch November 7, 2020 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants