[Refactor]Refactor config structure #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #488 +/- ##
=======================================
Coverage 84.76% 84.76%
=======================================
Files 121 121
Lines 8579 8579
Branches 1416 1416
=======================================
Hits 7272 7272
Misses 953 953
Partials 354 354
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
@xvjiarui can you help to review it ? |
xvjiarui
reviewed
Dec 28, 2020
|
kindly ping :p |
xvjiarui
approved these changes
Jan 14, 2021
congee524
force-pushed
the
refactor_config_structure
branch
from
0d9dd80
to
bef63b3
Compare
congee524
force-pushed
the
refactor_config_structure
branch
from
bef63b3
to
a7f2d41
Compare
hellock
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor config structure
I passed all the unittests and wrote a check function to determine the equivalence between the new config file and the old one