Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix CI bug due to mmcv index #495

Merged
merged 26 commits into from
Jan 10, 2021
Merged

Conversation

kennymckormick
Copy link
Member

No description provided.

@kennymckormick kennymckormick added the WIP work in progress label Dec 28, 2020
@innerlee
Copy link
Contributor

-q seems unrelated.

@dreamerlin dreamerlin linked an issue Dec 28, 2020 that may be closed by this pull request
@kennymckormick
Copy link
Member Author

-q seems unrelated.

just to check log, seems if -q added, nothing will be printed

@innerlee
Copy link
Contributor

Is this caused by mmdet? The CI was successful before

@kennymckormick
Copy link
Member Author

Is this caused by mmdet? The CI was successful before

Seems the mmcv with wrong version is installed in the cuda CI, see 2 screenshots below:
image
image

Try to find out why now.

@innerlee
Copy link
Contributor

Try to modify the cmd format first

image

@@ -999,5 +1000,5 @@ def train(self, mode=True):
m.eval()


if 'mmdet' in dir():
if mmdet_imported:
MMDET_SHARED_HEADS.register_module()(ResNet3dLayer)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is too weird. The following is more straight forward.

MMDET_SHARED_HEADS.register_module(ResNet3dLayer)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, registry.register_module() return a function,

@MMDET_SHARED_HEADS.register_module()
class ResNet3dLayer():
    pass

is equivalent to:

MMDET_SHARED_HEADS.register_module()(ResNet3dLayer)

@codecov
Copy link

codecov bot commented Dec 29, 2020

Codecov Report

Merging #495 (9f0bf1b) into master (54cddd7) will decrease coverage by 0.04%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #495      +/-   ##
==========================================
- Coverage   84.71%   84.66%   -0.05%     
==========================================
  Files         120      120              
  Lines        8407     8414       +7     
  Branches     1373     1373              
==========================================
+ Hits         7122     7124       +2     
- Misses        936      942       +6     
+ Partials      349      348       -1     
Flag Coverage Δ
unittests 84.65% <33.33%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...action/core/bbox/assigners/max_iou_assigner_ava.py 51.02% <33.33%> (-1.07%) ⬇️
mmaction/models/backbones/resnet3d.py 90.40% <33.33%> (-0.25%) ⬇️
mmaction/models/backbones/resnet3d_slowfast.py 84.21% <33.33%> (-0.50%) ⬇️
mmaction/models/backbones/resnet3d_slowonly.py 75.00% <33.33%> (-5.00%) ⬇️
mmaction/models/heads/bbox_head.py 80.32% <33.33%> (-0.67%) ⬇️
mmaction/models/heads/roi_head.py 28.26% <33.33%> (-0.63%) ⬇️
...maction/models/roi_extractors/single_straight3d.py 83.33% <33.33%> (-1.58%) ⬇️
mmaction/core/evaluation/accuracy.py 93.18% <0.00%> (+0.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54cddd7...9f0bf1b. Read the comment docs.

@innerlee
Copy link
Contributor

CI has been fixed in master, so you can remove changes in build.yaml

@kennymckormick kennymckormick removed the WIP work in progress label Dec 29, 2020
@kennymckormick
Copy link
Member Author

CI has been fixed in master, so you can remove changes in build.yaml

Maybe you can still merge my modification. Since there is no built wheel for torch1.5.1 (which means you still can not pass the GPU CI), I modify build.yml to run CI under torch1.5.0 + torchvision 0.6.0.

@kennymckormick kennymckormick changed the title Fix ci [Fix] Fix CI bug due to mmcv index Dec 29, 2020
@kennymckormick
Copy link
Member Author

kennymckormick commented Dec 29, 2020

CI has been fixed in master, so you can remove changes in build.yaml

Seems although https://download.openmmlab.com/mmcv/dist/cu101/torch1.5.1/index.html is an empty page, you can still install mmcv-full and pass the GPU CI. I'm not sure how does that happen, would you like to share the explanation with me?

@innerlee
Copy link
Contributor

🤷 have no idea.
Ask @ycxioooong

@ycxioooong
Copy link

@kennymckormick There is no built wheel for torch1.5.1 from a long time ago. We may have a discussion on this issue offline.

@dreamerlin
Copy link
Collaborator

How is it going ? @kennymckormick

@kennymckormick
Copy link
Member Author

How is it going ? @kennymckormick

I think OK to merge.

@innerlee innerlee merged commit 5ce7035 into open-mmlab:master Jan 10, 2021
@kennymckormick kennymckormick deleted the fixCI branch January 15, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI Failure
5 participants