Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add solution for markdown-lint installation issue #497

Merged
merged 3 commits into from Jan 16, 2021

Conversation

dreamerlin
Copy link
Collaborator

No description provided.

curl -L https://get.rvm.io | bash -s -- --autolibs=read-fail

# set up environment
echo 'source $HOME/.bash_profile' >> ~/.bashrc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line is not friendly


# set up environment
echo 'source $HOME/.bash_profile' >> ~/.bashrc
source ~/.profile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

@dreamerlin
Copy link
Collaborator Author

These commands are copied from mmdet. How about help to add script to install ruby>2.5 in setup repo ? Could you help it @innerlee

@dreamerlin
Copy link
Collaborator Author

These commands are copied from mmdet. How about help to add script to install ruby>2.5 in setup repo ? Could you help it @innerlee

ok i found it

@innerlee
Copy link
Contributor

btw the setup repo lacks some steps of post-installation. There are several env variables need to be defined. Do you have intersest to have a try, and find out the missing steps?

@dreamerlin
Copy link
Collaborator Author

btw the setup repo lacks some steps of post-installation. There are several env variables need to be defined. Do you have intersest to have a try, and find out the missing steps?

I am afraid I have no time these days. @congee524 , Could you help to do it?

@congee524
Copy link
Contributor

btw the setup repo lacks some steps of post-installation. There are several env variables need to be defined. Do you have intersest to have a try, and find out the missing steps?

I am afraid I have no time these days. @congee524 , Could you help to do it?

okk

@congee524
Copy link
Contributor

btw the setup repo lacks some steps of post-installation. There are several env variables need to be defined. Do you have intersest to have a try, and find out the missing steps?

Do you mean the missing steps in the process of installing ruby, or all the install scrips?

@innerlee
Copy link
Contributor

Sorry clicked the wrong button, didn't meant to approve this. My comments are still valid.

@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #497 (2a489c1) into master (264c3ad) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #497      +/-   ##
==========================================
- Coverage   84.69%   84.67%   -0.03%     
==========================================
  Files         120      121       +1     
  Lines        8407     8526     +119     
  Branches     1373     1398      +25     
==========================================
+ Hits         7120     7219      +99     
- Misses        938      953      +15     
- Partials      349      354       +5     
Flag Coverage Δ
unittests 84.65% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmaction/models/backbones/resnet3d_slowonly.py 75.00% <0.00%> (-5.00%) ⬇️
...maction/models/roi_extractors/single_straight3d.py 83.33% <0.00%> (-1.58%) ⬇️
mmaction/apis/train.py 13.63% <0.00%> (-1.37%) ⬇️
...action/core/bbox/assigners/max_iou_assigner_ava.py 51.02% <0.00%> (-1.07%) ⬇️
mmaction/models/heads/bbox_head.py 80.32% <0.00%> (-0.67%) ⬇️
mmaction/models/heads/roi_head.py 28.26% <0.00%> (-0.63%) ⬇️
mmaction/models/backbones/resnet3d_slowfast.py 84.21% <0.00%> (-0.50%) ⬇️
mmaction/models/backbones/resnet3d.py 90.40% <0.00%> (-0.25%) ⬇️
mmaction/utils/__init__.py 100.00% <0.00%> (ø)
mmaction/models/losses/cross_entropy_loss.py 100.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2345205...2a489c1. Read the comment docs.

@innerlee innerlee merged commit a6da544 into open-mmlab:master Jan 16, 2021
@dreamerlin dreamerlin deleted the md_contribution branch January 24, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants