Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Support --cfg-options for demos #911

Merged
merged 4 commits into from Jun 12, 2021

Conversation

dreamerlin
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #911 (fc56f6e) into master (f8b595a) will increase coverage by 0.11%.
The diff coverage is n/a.

❗ Current head fc56f6e differs from pull request most recent head 738d4ce. Consider uploading reports for the commit 738d4ce to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #911      +/-   ##
==========================================
+ Coverage   83.57%   83.69%   +0.11%     
==========================================
  Files         132      132              
  Lines        9966     9983      +17     
  Branches     1718     1722       +4     
==========================================
+ Hits         8329     8355      +26     
+ Misses       1218     1211       -7     
+ Partials      419      417       -2     
Flag Coverage Δ
unittests 83.69% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmaction/core/evaluation/accuracy.py 92.27% <0.00%> (-0.91%) ⬇️
mmaction/core/lr/tin_lr_hook.py
mmaction/core/lr/__init__.py
mmaction/core/scheduler/__init__.py 100.00% <0.00%> (ø)
mmaction/core/scheduler/lr_updater.py 96.55% <0.00%> (ø)
mmaction/datasets/pipelines/augmentations.py 92.87% <0.00%> (+0.22%) ⬆️
mmaction/models/recognizers/base.py 68.00% <0.00%> (+1.09%) ⬆️
mmaction/datasets/pipelines/formating.py 92.00% <0.00%> (+4.00%) ⬆️
mmaction/apis/inference.py 89.85% <0.00%> (+8.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8b595a...738d4ce. Read the comment docs.

Copy link
Member

@kennymckormick kennymckormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good, have you tried this new feature? (using --cfg-options to set options of type str, int, float, etc. )

demo/README.md Show resolved Hide resolved
@dreamerlin
Copy link
Collaborator Author

Looks Good, have you tried this new feature? (using --cfg-options to set options of type str, int, float, etc. )

It works well for all data type.

Copy link
Member

@kennymckormick kennymckormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged after some minor fixes

demo/README.md Outdated Show resolved Hide resolved
demo/README.md Outdated Show resolved Hide resolved
@dreamerlin dreamerlin merged commit f1df750 into open-mmlab:master Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants