Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Optimize IO for flow_warp #881

Merged
merged 2 commits into from May 10, 2022
Merged

Conversation

NK-CS-ZZL
Copy link
Contributor

This version of flow_warp is faster than original one and the consistency of results between two implementations has been checked.

@codecov
Copy link

codecov bot commented May 7, 2022

Codecov Report

Merging #881 (77d56cc) into master (52f6728) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #881      +/-   ##
==========================================
+ Coverage   83.14%   83.15%   +0.01%     
==========================================
  Files         221      221              
  Lines       12487    12488       +1     
  Branches     2026     2026              
==========================================
+ Hits        10382    10385       +3     
+ Misses       1787     1786       -1     
+ Partials      318      317       -1     
Flag Coverage Δ
unittests 83.11% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/models/common/flow_warp.py 100.00% <100.00%> (ø)
...ls/components/stylegan2/generator_discriminator.py 86.14% <0.00%> (+1.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52f6728...77d56cc. Read the comment docs.

@wangruohui
Copy link
Member

Fix #878

@wangruohui wangruohui changed the title [Enhance] a fast version of flow_warp [Enhance] Optimize IO for flow_warp May 8, 2022
@wangruohui wangruohui merged commit 334d003 into open-mmlab:master May 10, 2022
@NK-CS-ZZL NK-CS-ZZL deleted the warp branch May 11, 2022 00:13
wangruohui pushed a commit to wangruohui/mmediting that referenced this pull request Jul 7, 2022
Yshuo-Li pushed a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
Yshuo-Li pushed a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
Yshuo-Li pushed a commit to Yshuo-Li/mmediting that referenced this pull request Jul 16, 2022
@OpenMMLab-Assistant-004
Copy link

Hi @NK-CS-ZZL !First of all, we want to express our gratitude for your significant PR in the mmediting project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG

If you have WeChat,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants