Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DvcliveLoggerHook #1075

Merged
merged 4 commits into from
Jun 8, 2021
Merged

Add DvcliveLoggerHook #1075

merged 4 commits into from
Jun 8, 2021

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented Jun 2, 2021

Motivation

I would like to use https://dvc.org/doc/dvclive as a Logger.

Modification

I added a new LoggerHook child to the HOOKS registry.

Use cases (Optional)

Logging training parameters with dvclive (https://github.com/iterative/dvclive)

@daavoo daavoo mentioned this pull request Jun 2, 2021
5 tasks
@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #1075 (446eee0) into master (d212bd5) will increase coverage by 0.04%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1075      +/-   ##
==========================================
+ Coverage   65.72%   65.77%   +0.04%     
==========================================
  Files         157      158       +1     
  Lines       10092    10115      +23     
  Branches     1828     1831       +3     
==========================================
+ Hits         6633     6653      +20     
- Misses       3113     3115       +2     
- Partials      346      347       +1     
Flag Coverage Δ
unittests 65.77% <87.50%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/runner/__init__.py 100.00% <ø> (ø)
mmcv/runner/hooks/logger/dvclive.py 86.36% <86.36%> (ø)
mmcv/runner/hooks/__init__.py 100.00% <100.00%> (ø)
mmcv/runner/hooks/logger/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d212bd5...446eee0. Read the comment docs.

@daavoo daavoo requested a review from zhouzaida June 3, 2021 10:59
Copy link
Member

@zhouzaida zhouzaida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouzaida zhouzaida mentioned this pull request Jun 3, 2021
11 tasks
@ZwwWayne ZwwWayne merged commit bdd7022 into open-mmlab:master Jun 8, 2021
@daavoo daavoo deleted the dvclive-hook branch June 9, 2021 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants