Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhance] Differentiable rotated IoU #1854

Merged
merged 13 commits into from Apr 15, 2022
Merged

[Enhance] Differentiable rotated IoU #1854

merged 13 commits into from Apr 15, 2022

Conversation

filaPro
Copy link
Contributor

@filaPro filaPro commented Apr 2, 2022

Motivation

This PR adds Differentiable rotated IoU both 2d and 3d. It is discusses with @ZwwWayne and @Tai-Wang as a part of work on FCAF3D in mmdetection3d. It also can be used in mmrotate.

Modification

Just add a standart cuda op with python wrapper.

BC-breaking (Optional)

No

Use cases (Optional)

2d and 3d IoU loss.

@CLAassistant
Copy link

CLAassistant commented Apr 2, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@filaPro
Copy link
Contributor Author

filaPro commented Apr 2, 2022

Can you please guide me about build error?

    /opt/circleci/.pyenv/versions/3.8.0/lib/python3.8/site-packages/torch/include/ATen/cuda/CUDAContext.h:5:10: fatal error: cuda_runtime_api.h: No such file or directory

I'm not enough familiar with cuda and everything is fine on my side with torch==1.8.1 and cuda11.1.

@zhouzaida zhouzaida requested a review from grimoire April 3, 2022 15:11
@filaPro
Copy link
Contributor Author

filaPro commented Apr 3, 2022

The error for cpu build is fixed by using #ifdef MMCV_WITH_CUDA.

@grimoire
Copy link
Member

grimoire commented Apr 4, 2022

Thanks for the contribution! This is a guide about how to add custom ops in MMCV. Please update the code follow the steps.

@filaPro
Copy link
Contributor Author

filaPro commented Apr 5, 2022

Hi, @grimoire
I have refactored the structure according to the guide. Can you please have a look now?

@filaPro
Copy link
Contributor Author

filaPro commented Apr 7, 2022

Hi, @grimoire
Fixed almost all comments.

grimoire
grimoire approved these changes Apr 9, 2022
View reviewed changes
Copy link
Member

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouzaida zhouzaida requested a review from ZwwWayne April 10, 2022 02:36
@zhouzaida
Copy link
Member

Please @zytx121 have a look.

@zhouzaida
Copy link
Member

zhouzaida commented Apr 10, 2022 •
edited

Hi @filaPro , thanks for your contribution. The lint failed. Please refer to https://github.com/open-mmlab/mmcv/runs/5958604193?check_suite_focus=true to fix it.

BTW, we also need to add the op in https://github.com/open-mmlab/mmcv/blob/master/docs/en/understand_mmcv/ops.md and https://github.com/open-mmlab/mmcv/blob/master/docs/zh_cn/understand_mmcv/ops.md.

@zytx121
Copy link
Contributor

zytx121 commented Apr 10, 2022

@filaPro Good Job! I can't wait to use this PR in mmrotate.

@zytx121
Copy link
Contributor

zytx121 commented Apr 10, 2022 •
edited 

import torch
from mmcv.ops import diff_iou_rotated_2d

def iou_test_func():
    pred = torch.Tensor([[[7.8398e+02, 5.3547e+02, 4.9837e+01, 4.9745e+01, -5.5695e-03],
                          [7.8398e+02, 5.3547e+02, 4.9837e+01, 4.9745e+01, -5.5695e-03],
                          [7.8398e+02, 5.3547e+02, 4.9837e+01, 4.9745e+01, -5.5695e-03],
                          [7.8398e+02, 5.3547e+02, 4.9837e+01, 4.9745e+01, -5.5695e-03],
                          [7.8398e+02, 5.3547e+02, 4.9837e+01, 4.9745e+01, -5.5695e-03],
                          [2.5617e+02, 7.6878e+02, 7.2335e+01, 3.5456e+01, 1.5396e-02],
                          [2.5617e+02, 7.6878e+02, 7.2335e+01, 3.5456e+01, 1.5396e-02],
                          [2.5617e+02, 7.6878e+02, 7.2335e+01, 3.5456e+01, 1.5396e-02],
                          [2.5617e+02, 7.6878e+02, 7.2335e+01, 3.5456e+01, 1.5396e-02],
                          [2.5617e+02, 7.6878e+02, 7.2335e+01, 3.5456e+01, 1.5396e-02],
                          [2.6404e+02, 7.6876e+02, 7.2395e+01, 3.5374e+01, 1.3779e-02],
                          [2.6404e+02, 7.6876e+02, 7.2395e+01, 3.5374e+01, 1.3779e-02],
                          [2.6404e+02, 7.6876e+02, 7.2395e+01, 3.5374e+01, 1.3779e-02],
                          [2.6404e+02, 7.6876e+02, 7.2395e+01, 3.5374e+01, 1.3779e-02],
                          [2.6404e+02, 7.6876e+02, 7.2395e+01, 3.5374e+01, 1.3779e-02],
                          [2.7221e+02, 7.6876e+02, 7.2534e+01, 3.5422e+01, 1.0544e-02],
                          [2.7221e+02, 7.6876e+02, 7.2534e+01, 3.5422e+01, 1.0544e-02],
                          [2.7221e+02, 7.6876e+02, 7.2534e+01, 3.5422e+01, 1.0544e-02],
                          [2.7221e+02, 7.6876e+02, 7.2534e+01, 3.5422e+01, 1.0544e-02],
                          [2.7221e+02, 7.6876e+02, 7.2534e+01, 3.5422e+01, 1.0544e-02],
                          [2.4708e+02, 7.7564e+02, 5.6899e+01, 2.7976e+01, 4.4632e-03],
                          [2.4708e+02, 7.7564e+02, 5.6899e+01, 2.7976e+01, 4.4632e-03],
                          [2.4708e+02, 7.7564e+02, 5.6899e+01, 2.7976e+01, 4.4632e-03],
                          [2.4708e+02, 7.7564e+02, 5.6899e+01, 2.7976e+01, 4.4632e-03],
                          [2.4708e+02, 7.7564e+02, 5.6899e+01, 2.7976e+01, 4.4632e-03],
                          [2.4817e+02, 7.7670e+02, 7.2192e+01, 3.5333e+01, 1.9333e-02],
                          [2.4817e+02, 7.7670e+02, 7.2192e+01, 3.5333e+01, 1.9333e-02],
                          [2.4817e+02, 7.7670e+02, 7.2192e+01, 3.5333e+01, 1.9333e-02],
                          [2.4817e+02, 7.7670e+02, 7.2192e+01, 3.5333e+01, 1.9333e-02],
                          [2.4817e+02, 7.7670e+02, 7.2192e+01, 3.5333e+01, 1.9333e-02],
                          [2.5500e+02, 7.7572e+02, 5.6764e+01, 2.7944e+01, 4.6310e-03],
                          [2.5500e+02, 7.7572e+02, 5.6764e+01, 2.7944e+01, 4.6310e-03],
                          [2.5500e+02, 7.7572e+02, 5.6764e+01, 2.7944e+01, 4.6310e-03],
                          [2.5500e+02, 7.7572e+02, 5.6764e+01, 2.7944e+01, 4.6310e-03],
                          [2.5500e+02, 7.7572e+02, 5.6764e+01, 2.7944e+01, 4.6310e-03],
                          [2.5605e+02, 7.7674e+02, 7.2116e+01, 3.5306e+01, 1.8066e-02],
                          [2.5605e+02, 7.7674e+02, 7.2116e+01, 3.5306e+01, 1.8066e-02],
                          [2.5605e+02, 7.7674e+02, 7.2116e+01, 3.5306e+01, 1.8066e-02],
                          [2.5605e+02, 7.7674e+02, 7.2116e+01, 3.5306e+01, 1.8066e-02],
                          [2.5605e+02, 7.7674e+02, 7.2116e+01, 3.5306e+01, 1.8066e-02],
                          [2.6300e+02, 7.7577e+02, 5.6683e+01, 2.8090e+01, 7.4234e-03],
                          [2.6300e+02, 7.7577e+02, 5.6683e+01, 2.8090e+01, 7.4234e-03],
                          [2.6300e+02, 7.7577e+02, 5.6683e+01, 2.8090e+01, 7.4234e-03],
                          [2.6300e+02, 7.7577e+02, 5.6683e+01, 2.8090e+01, 7.4234e-03],
                          [2.6300e+02, 7.7577e+02, 5.6683e+01, 2.8090e+01, 7.4234e-03],
                          [2.6395e+02, 7.7679e+02, 7.2279e+01, 3.5197e+01, 1.7197e-02],
                          [2.6395e+02, 7.7679e+02, 7.2279e+01, 3.5197e+01, 1.7197e-02],
                          [2.6395e+02, 7.7679e+02, 7.2279e+01, 3.5197e+01, 1.7197e-02],
                          [2.6395e+02, 7.7679e+02, 7.2279e+01, 3.5197e+01, 1.7197e-02],
                          [2.6395e+02, 7.7679e+02, 7.2279e+01, 3.5197e+01, 1.7197e-02],
                          [2.7100e+02, 7.7573e+02, 5.6727e+01, 2.8060e+01, 4.9248e-03],
                          [2.7100e+02, 7.7573e+02, 5.6727e+01, 2.8060e+01, 4.9248e-03],
                          [2.7100e+02, 7.7573e+02, 5.6727e+01, 2.8060e+01, 4.9248e-03],
                          [2.7100e+02, 7.7573e+02, 5.6727e+01, 2.8060e+01, 4.9248e-03],
                          [2.7100e+02, 7.7573e+02, 5.6727e+01, 2.8060e+01, 4.9248e-03],
                          [2.7207e+02, 7.7671e+02, 7.2418e+01, 3.5077e+01, 1.3763e-02],
                          [2.7207e+02, 7.7671e+02, 7.2418e+01, 3.5077e+01, 1.3763e-02],
                          [2.7207e+02, 7.7671e+02, 7.2418e+01, 3.5077e+01, 1.3763e-02],
                          [2.7207e+02, 7.7671e+02, 7.2418e+01, 3.5077e+01, 1.3763e-02],
                          [2.7207e+02, 7.7671e+02, 7.2418e+01, 3.5077e+01, 1.3763e-02],
                          [2.7890e+02, 7.7560e+02, 5.6619e+01, 2.7964e+01, 5.5580e-03],
                          [2.7890e+02, 7.7560e+02, 5.6619e+01, 2.7964e+01, 5.5580e-03],
                          [2.7890e+02, 7.7560e+02, 5.6619e+01, 2.7964e+01, 5.5580e-03],
                          [2.7890e+02, 7.7560e+02, 5.6619e+01, 2.7964e+01, 5.5580e-03],
                          [2.7890e+02, 7.7560e+02, 5.6619e+01, 2.7964e+01, 5.5580e-03],
                          [2.8006e+02, 7.7672e+02, 7.2318e+01, 3.5115e+01, 1.6037e-02],
                          [2.8006e+02, 7.7672e+02, 7.2318e+01, 3.5115e+01, 1.6037e-02],
                          [2.8006e+02, 7.7672e+02, 7.2318e+01, 3.5115e+01, 1.6037e-02],
                          [2.8006e+02, 7.7672e+02, 7.2318e+01, 3.5115e+01, 1.6037e-02],
                          [2.8006e+02, 7.7672e+02, 7.2318e+01, 3.5115e+01, 1.6037e-02],
                          [5.5960e+01, 5.5911e+01, 4.5096e+01, 2.2615e+01, 1.1612e-02],
                          [5.5960e+01, 5.5911e+01, 4.5096e+01, 2.2615e+01, 1.1612e-02],
                          [5.5960e+01, 5.5911e+01, 4.5096e+01, 2.2615e+01, 1.1612e-02],
                          [5.5960e+01, 5.5911e+01, 4.5096e+01, 2.2615e+01, 1.1612e-02],
                          [5.5960e+01, 5.5911e+01, 4.5096e+01, 2.2615e+01, 1.1612e-02],
                          [6.4040e+01, 5.6091e+01, 3.2078e+01, 3.1835e+01, 6.6414e-03],
                          [6.4040e+01, 5.6091e+01, 3.2078e+01, 3.1835e+01, 6.6414e-03],
                          [6.4040e+01, 5.6091e+01, 3.2078e+01, 3.1835e+01, 6.6414e-03],
                          [6.4040e+01, 5.6091e+01, 3.2078e+01, 3.1835e+01, 6.6414e-03],
                          [6.4040e+01, 5.6091e+01, 3.2078e+01, 3.1835e+01, 6.6414e-03],
                          [6.3961e+01, 5.5956e+01, 4.5087e+01, 2.2681e+01, 8.7662e-03],
                          [6.3961e+01, 5.5956e+01, 4.5087e+01, 2.2681e+01, 8.7662e-03],
                          [6.3961e+01, 5.5956e+01, 4.5087e+01, 2.2681e+01, 8.7662e-03],
                          [6.3961e+01, 5.5956e+01, 4.5087e+01, 2.2681e+01, 8.7662e-03],
                          [6.3961e+01, 5.5956e+01, 4.5087e+01, 2.2681e+01, 8.7662e-03],
                          [7.1877e+01, 5.5947e+01, 4.5007e+01, 2.2700e+01, 7.8201e-03],
                          [7.1877e+01, 5.5947e+01, 4.5007e+01, 2.2700e+01, 7.8201e-03],
                          [7.1877e+01, 5.5947e+01, 4.5007e+01, 2.2700e+01, 7.8201e-03],
                          [7.1877e+01, 5.5947e+01, 4.5007e+01, 2.2700e+01, 7.8201e-03],
                          [7.1877e+01, 5.5947e+01, 4.5007e+01, 2.2700e+01, 7.8201e-03]]])

    target = torch.Tensor([[[7.7984e+02, 5.3328e+02, 8.2462e+01, 2.9056e+01, 6.8232e-01],
                            [7.7984e+02, 5.3328e+02, 8.2462e+01, 2.9056e+01, 6.8232e-01],
                            [7.7984e+02, 5.3328e+02, 8.2462e+01, 2.9056e+01, 6.8232e-01],
                            [7.7984e+02, 5.3328e+02, 8.2462e+01, 2.9056e+01, 6.8232e-01],
                            [7.7984e+02, 5.3328e+02, 8.2462e+01, 2.9056e+01, 6.8232e-01],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [2.6450e+02, 7.7400e+02, 8.9354e+01, 3.0998e+01, 1.1236e-02],
                            [6.4000e+01, 5.6000e+01, 3.0000e+01, 1.8000e+01, -1.1921e-07],
                            [6.4000e+01, 5.6000e+01, 3.0000e+01, 1.8000e+01, -1.1921e-07],
                            [6.4000e+01, 5.6000e+01, 3.0000e+01, 1.8000e+01, -1.1921e-07],
                            [6.4000e+01, 5.6000e+01, 3.0000e+01, 1.8000e+01, -1.1921e-07],
                            [6.4000e+01, 5.6000e+01, 3.0000e+01, 1.8000e+01, -1.1921e-07],
                            [6.4000e+01, 5.6000e+01, 3.0000e+01, 1.8000e+01, -1.1921e-07],
                            [6.4000e+01, 5.6000e+01, 3.0000e+01, 1.8000e+01, -1.1921e-07],
                            [6.4000e+01, 5.6000e+01, 3.0000e+01, 1.8000e+01, -1.1921e-07],
                            [6.4000e+01, 5.6000e+01, 3.0000e+01, 1.8000e+01, -1.1921e-07],
                            [6.4000e+01, 5.6000e+01, 3.0000e+01, 1.8000e+01, -1.1921e-07],
                            [6.4000e+01, 5.6000e+01, 3.0000e+01, 1.8000e+01, -1.1921e-07],
                            [6.4000e+01, 5.6000e+01, 3.0000e+01, 1.8000e+01, -1.1921e-07],
                            [6.4000e+01, 5.6000e+01, 3.0000e+01, 1.8000e+01, -1.1921e-07],
                            [6.4000e+01, 5.6000e+01, 3.0000e+01, 1.8000e+01, -1.1921e-07],
                            [6.4000e+01, 5.6000e+01, 3.0000e+01, 1.8000e+01, -1.1921e-07],
                            [6.4000e+01, 5.6000e+01, 3.0000e+01, 1.8000e+01, -1.1921e-07],
                            [6.4000e+01, 5.6000e+01, 3.0000e+01, 1.8000e+01, -1.1921e-07],
                            [6.4000e+01, 5.6000e+01, 3.0000e+01, 1.8000e+01, -1.1921e-07],
                            [6.4000e+01, 5.6000e+01, 3.0000e+01, 1.8000e+01, -1.1921e-07],
                            [6.4000e+01, 5.6000e+01, 3.0000e+01, 1.8000e+01, -1.1921e-07]]])
    

    pred = pred.repeat(1,1000,1).cuda()
    target = target.repeat(1,1000,1).cuda()
    ious = diff_iou_rotated_2d(pred, target)
    ious.cpu()


iou_test_func()

Hi @filaPro
When test in mmrotate, there is a bug:
RuntimeError: CUDA error: an illegal memory access was encountered

@filaPro
Copy link
Contributor Author

filaPro commented Apr 11, 2022

Hi @zytx121,
Thx for reporting. It was an inaccurate fix of @grimoire comment about indexing in the nested for loops. j-1 index became out of bounds when j==0.

@filaPro
Copy link
Contributor Author

filaPro commented Apr 12, 2022

Also don't quite undersrand lint problems. Everything is fine on my side.

@zhouzaida
Copy link
Member

Also don't quite undersrand lint problems. Everything is fine on my side.

You can click https://github.com/open-mmlab/mmcv/runs/5983405663?check_suite_focus=true to see what happens.

@filaPro
Copy link
Contributor Author

filaPro commented Apr 12, 2022

Oh, I see, clang-format is disabled in pre-commit-config by default.

@zytx121
Copy link
Contributor

zytx121 commented Apr 13, 2022

LGTM

zytx121
zytx121 reviewed Apr 13, 2022
View reviewed changes
mmcv/ops/diff_iou_rotated.py Outdated Show resolved Hide resolved
mmcv/ops/diff_iou_rotated.py Outdated Show resolved Hide resolved
mmcv/ops/diff_iou_rotated.py Outdated Show resolved Hide resolved
mmcv/ops/diff_iou_rotated.py Show resolved Hide resolved
mmcv/ops/diff_iou_rotated.py Outdated Show resolved Hide resolved
mmcv/ops/diff_iou_rotated.py Show resolved Hide resolved
ZwwWayne
ZwwWayne reviewed Apr 13, 2022
View reviewed changes
mmcv/ops/diff_iou_rotated.py Outdated Show resolved Hide resolved
mmcv/ops/diff_iou_rotated.py Outdated Show resolved Hide resolved
mmcv/ops/diff_iou_rotated.py Show resolved Hide resolved
mmcv/ops/diff_iou_rotated.py Outdated Show resolved Hide resolved
mmcv/ops/diff_iou_rotated.py Outdated Show resolved Hide resolved
mmcv/ops/diff_iou_rotated.py Outdated Show resolved Hide resolved
@liuyanyi liuyanyi mentioned this pull request Apr 14, 2022
Merged
7 tasks
ZwwWayne
ZwwWayne reviewed Apr 14, 2022
View reviewed changes
mmcv/ops/diff_iou_rotated.py Outdated Show resolved Hide resolved
mmcv/ops/diff_iou_rotated.py Outdated Show resolved Hide resolved
mmcv/ops/diff_iou_rotated.py Outdated Show resolved Hide resolved
@ZwwWayne
Copy link
Collaborator

The lint issue is caused by other PR that is unrelated to this PR. The failure in CI should also be fixed in master. Therefore, merging this PR should be safe.

@ZwwWayne ZwwWayne merged commit aee596d into open-mmlab:master Apr 15, 2022
@filaPro filaPro deleted the diff_iou_rotated branch April 15, 2022 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zytx121 zytx121 zytx121 left review comments

@ZwwWayne ZwwWayne ZwwWayne left review comments

@grimoire grimoire grimoire approved these changes

Assignees

@HAOCHENYE HAOCHENYE

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@filaPro @CLAassistant @grimoire @zhouzaida @zytx121 @ZwwWayne @HAOCHENYE