Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Fix some mistakes in data_process.md #2283

Merged
merged 2 commits into from
Sep 25, 2022

Conversation

yxzhao2022
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Sep 24, 2022

CLA assistant check
All committers have signed the CLA.

@zhouzaida zhouzaida added this to TO PICK in MMCV 1.x Sep 25, 2022
@zhouzaida
Copy link
Member

Hi @yxzhao2022 , thanks for your contribution and could you help update the en docs in https://github.com/open-mmlab/mmcv/blob/2.x/docs/en/understand_mmcv/data_process.md.

@zhouzaida zhouzaida changed the title [Docs]Correct some mistakes [Docs] Correct some mistakes in data_process.md Sep 25, 2022
@zhouzaida zhouzaida changed the title [Docs] Correct some mistakes in data_process.md [Docs] Fix some mistakes in data_process.md Sep 25, 2022
@zhouzaida zhouzaida merged commit c57b8b1 into open-mmlab:2.x Sep 25, 2022
@yxzhao2022 yxzhao2022 deleted the 2.x-test branch September 25, 2022 08:20
zhouzaida pushed a commit to zhouzaida/mmcv that referenced this pull request Sep 25, 2022
zhouzaida added a commit that referenced this pull request Sep 25, 2022
* [Fix] Fix the calculation error of out_w in MaskedConv2dFunction (#2264)

* [Fix] Fix two intergers can not use / operator in torch1.6

* should not use kernel_h when calculates out_w

* [Docs] Fix some mistakes in data_process.md (#2283)

* correction

* correction en docs

Co-authored-by: yxzhao <33384732+yxzhao2022@users.noreply.github.com>
@zhouzaida zhouzaida moved this from TO PICK to PICKED in MMCV 1.x Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MMCV 1.x
PICKED
Development

Successfully merging this pull request may close these issues.

None yet

4 participants