Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix _flip_keypoint of RandomFlip returns the wrong result #2527

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

zhouzaida
Copy link
Member

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

resolves #2526

_flip_keypoint of RandomFlip returns the wrong result. _flip_keypoint should concatenate the flipped rather than input keypoints.

Modification

_flip_keypoint of RandomFlip

BC-breaking (Optional)

No

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@ly015
Copy link
Member

ly015 commented Jan 6, 2023

LGTM

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Base: 66.34% // Head: 66.34% // No change to project coverage 👍

Coverage data is based on head (d235bdf) compared to base (4ae327f).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head d235bdf differs from pull request most recent head 6f82596. Consider uploading reports for the commit 6f82596 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #2527   +/-   ##
=======================================
  Coverage   66.34%   66.34%           
=======================================
  Files         120      120           
  Lines        7746     7746           
  Branches     1074     1074           
=======================================
  Hits         5139     5139           
  Misses       2438     2438           
  Partials      169      169           
Flag Coverage Δ
unittests 66.34% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/transforms/processing.py 94.67% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zhouzaida zhouzaida merged commit fadd915 into open-mmlab:2.x Jan 6, 2023
@zhouzaida zhouzaida deleted the fix-randomflip branch January 6, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants