Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Support mmcv ext with DIOPI impl #2790

Merged
merged 29 commits into from
Jun 13, 2023
Merged

[Feature] Support mmcv ext with DIOPI impl #2790

merged 29 commits into from
Jun 13, 2023

Conversation

CokeDong
Copy link
Contributor

@CokeDong CokeDong commented May 5, 2023

Support mmcv ext+dipu

This was referenced May 11, 2023
Open
Open
Open
@CokeDong CokeDong changed the title Support mmcv ext+dipu Support mmcv ext with DIOPI impl May 11, 2023
@zhouzaida zhouzaida requested a review from grimoire June 7, 2023 03:18
grimoire
grimoire reviewed Jun 7, 2023
View reviewed changes
setup.py Show resolved Hide resolved
grimoire
grimoire reviewed Jun 7, 2023
View reviewed changes
mmcv/ops/focal_loss.py Outdated Show resolved Hide resolved
@grimoire
Copy link
Member

grimoire commented Jun 7, 2023

how to build mmcv with dipu?

@CokeDong
Copy link
Contributor Author

CokeDong commented Jun 7, 2023

how to build mmcv with dipu?

e.g. MMCV_WITH_DIOPI=1 MMCV_WITH_OPS=1 python setup.py build_ext -i

@grimoire
Copy link
Member

grimoire commented Jun 7, 2023 •
edited

Is there any guide about how to setup DIPU_ROOT, DIOPI_PATH and DIPU_PATH? I guess one of it is DIOPI-IMPL/proto/include/?

grimoire
grimoire reviewed Jun 7, 2023
View reviewed changes
setup.py Show resolved Hide resolved
grimoire
grimoire approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhouzaida
zhouzaida reviewed Jun 12, 2023
View reviewed changes
setup.py Show resolved Hide resolved
zhouzaida
zhouzaida reviewed Jun 13, 2023
View reviewed changes
setup.py Outdated Show resolved Hide resolved
@zhouzaida zhouzaida changed the title Support mmcv ext with DIOPI impl [Feature] Support mmcv ext with DIOPI impl Jun 13, 2023
@zhouzaida zhouzaida merged commit 9b1209f into open-mmlab:main Jun 13, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grimoire grimoire grimoire approved these changes

@zhouzaida zhouzaida zhouzaida approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CokeDong @grimoire @zhouzaida