[Fix] Fix typehint in _scale_size and rescale_size
#2799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
zhouzaida
reviewed
May 18, 2023
mmcv/image/geometric.py
Outdated
| @@ -27,7 +27,7 @@ def _scale_size( | |||
| Returns: | |||
| tuple[int]: scaled size. | |||
| """ | |||
| if isinstance(scale, (float, int)): | |||
| if isinstance(scale, float): | |||
There was a problem hiding this comment.
Hi @MambaWong , scale should support accepting int type so we only need to update the docstring.
There was a problem hiding this comment.
Hi @zhouzaida, I'm confused about the need for int, can you give some example?
There was a problem hiding this comment.
Hi, this is just for the convenience of the user, for example, if you want to double the size of the image, you can pass in 2, but of course, you can also pass in 2.0.
zhouzaida
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.