Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coreml #1658

Merged
merged 3 commits into from Jan 19, 2023
Merged

Fix coreml #1658

merged 3 commits into from Jan 19, 2023

Conversation

grimoire
Copy link
Member

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@irexyc
Copy link
Collaborator

irexyc commented Jan 16, 2023

Please fix the lint error.

It's fine to fix #1652

For some model like resnet18_8xb32_in1k.py, we can only deploy the model with dynamic batch. However, If we deploy the model with shape 224-256, the conversion process goes well, but we can't load the converted model.

/Users/cx/opt/miniforge3/envs/mm/lib/python3.9/site-packages/coremltools/models/model.py:145: RuntimeWarning: You will not be able to run predict() on this Core ML model. Underlying exception message was: {
    NSLocalizedDescription = "Error in declaring network.";
}
  _warnings.warn(

@grimoire grimoire added this to NewPR in MMDeploy 1.x Jan 16, 2023
@grimoire grimoire merged commit 513b1c3 into open-mmlab:master Jan 19, 2023
@grimoire grimoire moved this from NewPR to PICKED in MMDeploy 1.x Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants