Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deform conv v3 plugin #1872

Merged
merged 4 commits into from May 23, 2023
Merged

Conversation

AllentDan
Copy link
Member

I did not add a unit test since no PyTorch implementation is available in MMCV.

@RunningLeon RunningLeon requested a review from grimoire May 6, 2023 06:20
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Patch coverage: 11.26% and project coverage change: +0.48 🎉

Comparison is base (0737a59) 44.46% compared to head (7b1df10) 44.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1872      +/-   ##
==========================================
+ Coverage   44.46%   44.94%   +0.48%     
==========================================
  Files         356      360       +4     
  Lines       12582    13106     +524     
  Branches     1796     1855      +59     
==========================================
+ Hits         5595     5891     +296     
- Misses       6594     6803     +209     
- Partials      393      412      +19     
Flag Coverage Δ
unittests 44.94% <11.26%> (+0.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdeploy/apis/visualize.py 17.14% <0.00%> (-0.51%) ⬇️
mmdeploy/backend/ascend/backend_manager.py 44.44% <0.00%> (+0.32%) ⬆️
mmdeploy/backend/ascend/wrapper.py 0.00% <0.00%> (ø)
mmdeploy/backend/coreml/torchscript2coreml.py 0.00% <0.00%> (ø)
...debase/mmdet/models/dense_heads/base_dense_head.py 25.69% <ø> (-0.11%) ⬇️
...det/models/roi_heads/single_level_roi_extractor.py 42.60% <0.00%> (+0.56%) ⬆️
mmdeploy/backend/coreml/backend_manager.py 32.65% <4.76%> (-15.74%) ⬇️
...oy/codebase/mmdet/core/post_processing/bbox_nms.py 62.56% <21.42%> (-1.64%) ⬇️
mmdeploy/pytorch/functions/topk.py 50.00% <30.00%> (-6.25%) ⬇️
mmdeploy/codebase/mmdet/deploy/utils.py 69.52% <100.00%> (+1.20%) ⬆️

... and 155 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RunningLeon RunningLeon self-requested a review May 23, 2023 02:19
Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RunningLeon RunningLeon merged commit 6cd77c6 into open-mmlab:master May 23, 2023
22 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
MMDeploy 1.x
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

3 participants