fix pose_tracker python api will raise ValueError when result has no human #1922
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There is a bug in Python binding of PoseTracker. When inference result has no human body, there is possibility that a
ValueError: negative dimensions are not allowed numpy
exception raised. I made some digging and found that:Result
object is created butkeypoint_count
is uninitialized;py::array_t
in Python versionApply
function,keypoint_count
is used to initialize the array shape;keypoint_count
is random value, when it is negative, thepy::array_t
would fail to create.Modification
Add a check before reading
keypoint_count
.BC-breaking (Optional)
No.
Use cases (Optional)
No.
Checklist