Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] hide progress if requested w/ show_progress = False #10519

Merged
merged 3 commits into from
Jun 19, 2023

Conversation

amaizr
Copy link
Contributor

@amaizr amaizr commented Jun 15, 2023

Motivation

set .show_progress = False on detector but progress is still showing.

Modification

dont wrap inputs in track if not show_progress

BC-breaking (Optional)

this should fix a bug in not honoring show_progress

Use cases (Optional)

n/a

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Jun 15, 2023

CLA assistant check
All committers have signed the CLA.

@amaizr amaizr changed the title hide progress if requested w/ show_progress = False [Fix] hide progress if requested w/ show_progress = False Jun 15, 2023
hhaAndroid
hhaAndroid previously approved these changes Jun 19, 2023
@hhaAndroid hhaAndroid changed the base branch from main to dev-3.x June 19, 2023 02:53
@hhaAndroid hhaAndroid dismissed their stale review June 19, 2023 02:53

The base branch was changed.

@hhaAndroid hhaAndroid merged commit ab41de9 into open-mmlab:dev-3.x Jun 19, 2023
4 of 8 checks passed
@OpenMMLab-Assistant-004

Hi @amaizr,

We'd like to express our appreciation for your valuable contributions to the mmdetection. Your efforts have significantly aided in enhancing the project's quality.
It is our pleasure to invite you to join our community thorugh Discord_Special Interest Group (SIG) channel. This is a great place to share your experiences, discuss ideas, and connect with other like-minded people. To become a part of the SIG channel, send a message to the moderator, OpenMMLab, briefly introduce yourself and mention your open-source contributions in the #introductions channel. Our team will gladly facilitate your entry. We eagerly await your presence. Please follow this link to join us: ​https://discord.gg/UjgXkPWNqA.

If you're on WeChat, we'd also love for you to join our community there. Just add our assistant using the WeChat ID: openmmlabwx. When sending the friend request, remember to include the remark "mmsig + Github ID".

Thanks again for your awesome contribution, and we're excited to have you as part of our community!

yumion pushed a commit to yumion/mmdetection that referenced this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants