fix a bug of pisa loss, when some images in one batch images have no gts. #2992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhcao6
approved these changes
Jun 12, 2020
hellock
approved these changes
Jun 12, 2020
mike112223
pushed a commit
to mike112223/mmdetection
that referenced
this pull request
Aug 25, 2020
liuhuiCNN
pushed a commit
to liuhuiCNN/mmdetection
that referenced
this pull request
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If some images in one batch images have no gts, there might be a bug in line 53 of pisa loss (can not perform
gt_i.max()). This PR has already been discussed with yuhang.