Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix (base.py): fix with_xxx_attributes in base detector #3567

Merged
merged 1 commit into from
Aug 16, 2020

Conversation

ZwwWayne
Copy link
Collaborator

Fix #3444

@ZwwWayne ZwwWayne requested a review from yhcao6 August 16, 2020 15:44
@codecov
Copy link

codecov bot commented Aug 16, 2020

Codecov Report

Merging #3567 into master will increase coverage by 0.06%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3567      +/-   ##
==========================================
+ Coverage   59.04%   59.10%   +0.06%     
==========================================
  Files         205      205              
  Lines       13731    13731              
  Branches     2315     2315              
==========================================
+ Hits         8107     8116       +9     
+ Misses       5248     5239       -9     
  Partials      376      376              
Flag Coverage Δ
#unittests 59.10% <66.66%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/models/detectors/base.py 51.14% <66.66%> (ø)
mmdet/models/dense_heads/corner_head.py 76.04% <0.00%> (+1.94%) ⬆️
mmdet/models/detectors/cornernet.py 100.00% <0.00%> (+5.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04c44d0...da6a20e. Read the comment docs.

@hellock hellock merged commit 6acf6be into open-mmlab:master Aug 16, 2020
@ZwwWayne ZwwWayne deleted the fix-3444 branch August 14, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attribute error with RetinaNet and with_mask, with_bbox, with_neck, with_shared_head
3 participants