Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] typo #3741

Merged
merged 2 commits into from
Sep 12, 2020
Merged

[fix] typo #3741

merged 2 commits into from
Sep 12, 2020

Conversation

jd730
Copy link
Contributor

@jd730 jd730 commented Sep 11, 2020

fix typo in the comment:
my also contain -> may also contain

my also contain -> may also contain
@CLAassistant
Copy link

CLAassistant commented Sep 11, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #3741 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3741      +/-   ##
==========================================
- Coverage   61.09%   60.95%   -0.14%     
==========================================
  Files         217      217              
  Lines       15374    15374              
  Branches     2628     2628              
==========================================
- Hits         9392     9371      -21     
- Misses       5513     5534      +21     
  Partials      469      469              
Flag Coverage Δ
#unittests 60.95% <ø> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/core/post_processing/merge_augs.py 80.35% <ø> (ø)
mmdet/models/detectors/base.py 50.76% <ø> (ø)
mmdet/models/roi_heads/test_mixins.py 50.44% <0.00%> (-9.74%) ⬇️
mmdet/models/detectors/cornernet.py 94.87% <0.00%> (-5.13%) ⬇️
mmdet/models/dense_heads/corner_head.py 74.31% <0.00%> (-1.92%) ⬇️
mmdet/core/bbox/assigners/max_iou_assigner.py 72.36% <0.00%> (-1.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 039ad4d...da23bd9. Read the comment docs.

@shinya7y
Copy link
Contributor

The same typo could be fixed at the same time.

'img_shape', 'scale_factor', 'flip', and my also contain

@hellock
Copy link
Member

hellock commented Sep 11, 2020

Could you sign the CLA?

@jd730
Copy link
Contributor Author

jd730 commented Sep 12, 2020

Hi @shinya7y, I fixed it now.
Hi @hellock, I signed it.

@hellock hellock merged commit 11b1ef8 into open-mmlab:master Sep 12, 2020
liuhuiCNN pushed a commit to liuhuiCNN/mmdetection that referenced this pull request May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants