Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhance]: Use RoIAlign implemented in MMCV for inference in CPU mode #3930

Merged
merged 3 commits into from Oct 19, 2020

Conversation

RunningLeon
Copy link
Collaborator

Since RoIAlign in mmcv.ops is supported with aligned=False in CPU mode, there's no need to use the op from torchvision in CPU mode.

@CLAassistant
Copy link

CLAassistant commented Oct 14, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #3930 into master will decrease coverage by 0.04%.
The diff coverage is 88.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3930      +/-   ##
==========================================
- Coverage   62.27%   62.23%   -0.05%     
==========================================
  Files         221      221              
  Lines       16310    16305       -5     
  Branches     2755     2756       +1     
==========================================
- Hits        10157    10147      -10     
- Misses       5659     5666       +7     
+ Partials      494      492       -2     
Flag Coverage Δ
#unittests 62.23% <88.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/models/dense_heads/paa_head.py 91.59% <ø> (+1.17%) ⬆️
mmdet/models/roi_heads/cascade_roi_head.py 71.19% <33.33%> (-0.60%) ⬇️
mmdet/apis/inference.py 21.51% <50.00%> (+0.78%) ⬆️
...mdet/core/bbox/iou_calculators/iou2d_calculator.py 96.77% <100.00%> (+8.31%) ⬆️
mmdet/models/losses/iou_loss.py 37.71% <100.00%> (-5.07%) ⬇️
mmdet/models/roi_heads/test_mixins.py 50.42% <0.00%> (-9.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 502cee2...f687768. Read the comment docs.

@ZwwWayne ZwwWayne self-requested a review October 14, 2020 12:25
@RunningLeon RunningLeon changed the title [enhance]: RoIAlign in mmcv is supported with aligned=False in CPU mode [enhance]: Use RoIAlign implemented in MMCV for inference in CPU mode Oct 14, 2020
mmdet/apis/inference.py Outdated Show resolved Hide resolved
mmdet/apis/inference.py Outdated Show resolved Hide resolved
@ZwwWayne ZwwWayne merged commit 9caa197 into open-mmlab:master Oct 19, 2020
@RunningLeon RunningLeon deleted the dev branch October 20, 2020 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants