Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix img_norm in hrnet when using fcos detector #4250

Merged
merged 4 commits into from
Dec 15, 2020

Conversation

v-qjqs
Copy link
Contributor

@v-qjqs v-qjqs commented Dec 8, 2020

This PR fix #4232, fix different img_norm in hrnet when using fcos.

@codecov
Copy link

codecov bot commented Dec 8, 2020

Codecov Report

Merging #4250 (783f04c) into master (c551b59) will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4250      +/-   ##
==========================================
- Coverage   62.70%   62.51%   -0.19%     
==========================================
  Files         235      232       -3     
  Lines       17821    17597     -224     
  Branches     2984     2942      -42     
==========================================
- Hits        11174    11001     -173     
+ Misses       6103     6060      -43     
+ Partials      544      536       -8     
Flag Coverage Δ
unittests 62.48% <ø> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/models/roi_heads/mask_scoring_roi_head.py 55.35% <0.00%> (-32.15%) ⬇️
mmdet/models/roi_heads/test_mixins.py 45.73% <0.00%> (-8.53%) ⬇️
mmdet/models/roi_heads/mask_heads/maskiou_head.py 94.62% <0.00%> (-5.38%) ⬇️
mmdet/datasets/samplers/distributed_sampler.py 29.41% <0.00%> (-3.93%) ⬇️
mmdet/models/roi_heads/mask_heads/fcn_mask_head.py 70.55% <0.00%> (-1.23%) ⬇️
mmdet/models/roi_heads/dynamic_roi_head.py 25.00% <0.00%> (-0.38%) ⬇️
mmdet/models/necks/fpn.py 93.82% <0.00%> (-0.23%) ⬇️
mmdet/models/backbones/resnet.py 99.30% <0.00%> (ø)
mmdet/models/backbones/__init__.py 100.00% <0.00%> (ø)
mmdet/models/detectors/__init__.py 100.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c551b59...41bc971. Read the comment docs.

@hellock
Copy link
Member

hellock commented Dec 8, 2020

There are linting errors.

@ZwwWayne ZwwWayne merged commit 231387c into open-mmlab:master Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Different mean values of image normalization for HRNet
3 participants