Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move train_cfg/test_cfg into model #4347

Merged
merged 3 commits into from Jan 18, 2021
Merged

Conversation

xvjiarui
Copy link
Collaborator

No description provided.

@xvjiarui xvjiarui added the WIP Working in progress label Dec 24, 2020
@codecov
Copy link

codecov bot commented Dec 24, 2020

Codecov Report

Merging #4347 (81922a4) into master (0c84b65) will increase coverage by 0.11%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4347      +/-   ##
==========================================
+ Coverage   61.88%   61.99%   +0.11%     
==========================================
  Files         240      241       +1     
  Lines       18267    18357      +90     
  Branches     3058     3075      +17     
==========================================
+ Hits        11304    11381      +77     
- Misses       6416     6419       +3     
- Partials      547      557      +10     
Flag Coverage Δ
unittests 61.96% <33.33%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/apis/inference.py 19.76% <0.00%> (+0.22%) ⬆️
mmdet/core/export/pytorch2onnx.py 17.39% <0.00%> (-0.39%) ⬇️
mmdet/models/builder.py 93.93% <60.00%> (-6.07%) ⬇️
mmdet/core/post_processing/bbox_nms.py 83.05% <0.00%> (-2.92%) ⬇️
mmdet/core/bbox/samplers/sampling_result.py 73.01% <0.00%> (-1.59%) ⬇️
mmdet/models/roi_heads/test_mixins.py 45.03% <0.00%> (-0.70%) ⬇️
mmdet/datasets/voc.py 25.00% <0.00%> (-0.59%) ⬇️
mmdet/models/dense_heads/cascade_rpn_head.py 28.07% <0.00%> (-0.20%) ⬇️
mmdet/models/dense_heads/atss_head.py 27.94% <0.00%> (ø)
mmdet/ops/__init__.py
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c84b65...81922a4. Read the comment docs.

@xvjiarui xvjiarui removed the WIP Working in progress label Dec 24, 2020
@ZwwWayne
Copy link
Collaborator

LGTM, see if @hellock has any comments.

@xvjiarui
Copy link
Collaborator Author

Kindly ping @hellock

@ZwwWayne
Copy link
Collaborator

  1. We also need to update documentation about configs, including the config examples.
  2. Add deprecation notification in the documentation about configs.

@hhaAndroid
Copy link
Collaborator

@xvjiarui I tested all models using batch_test.py without checkpoint and find missed modifying the following configuration:

1 configs/faster_rcnn/faster_rcnn_r50_fpn_soft_nms_1x_coco.py
2 configs/faster_rcnn/faster_rcnn_r50_fpn_ohem_1x_coco.py
3 configs/lvis/mask_rcnn_r50_fpn_sample1e-3_mstrain_1x_lvis_v1.py
4 configs/lvis/mask_rcnn_r50_fpn_sample1e-3_mstrain_2x_lvis_v0.5.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants