Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement Deformable-detr #4778

Merged
merged 79 commits into from
Apr 28, 2021
Merged

Conversation

jshilong
Copy link
Collaborator

No description provided.

@jshilong jshilong added the WIP Working in progress label Mar 16, 2021
configs/deformable_detr/README.md Outdated Show resolved Hide resolved
configs/deformable_detr/README.md Outdated Show resolved Hide resolved
mmdet/models/dense_heads/detr_head.py Show resolved Hide resolved
mmdet/models/detectors/detr.py Outdated Show resolved Hide resolved
mmdet/models/utils/transformer.py Show resolved Hide resolved
mmdet/models/utils/transformer.py Outdated Show resolved Hide resolved
@jshilong jshilong requested a review from ZwwWayne April 27, 2021 13:28
configs/deformable_detr/README.md Outdated Show resolved Hide resolved
configs/deformable_detr/README.md Outdated Show resolved Hide resolved
configs/deformable_detr/README.md Show resolved Hide resolved
mmdet/models/utils/transformer.py Outdated Show resolved Hide resolved
@ZwwWayne
Copy link
Collaborator

Last round, can be merged after comments are resolved.

@ZwwWayne
Copy link
Collaborator

resolve conflicts

@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #4778 (c08fb44) into master (0425fb6) will decrease coverage by 0.51%.
The diff coverage is 34.25%.

❗ Current head c08fb44 differs from pull request most recent head a19c7f0. Consider uploading reports for the commit a19c7f0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4778      +/-   ##
==========================================
- Coverage   66.03%   65.52%   -0.52%     
==========================================
  Files         261      263       +2     
  Lines       20306    20633     +327     
  Branches     3466     3523      +57     
==========================================
+ Hits        13410    13519     +109     
- Misses       6156     6375     +219     
+ Partials      740      739       -1     
Flag Coverage Δ
unittests 65.48% <34.25%> (-0.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/models/utils/__init__.py 100.00% <ø> (ø)
mmdet/models/utils/transformer.py 48.07% <24.00%> (-38.30%) ⬇️
mmdet/models/dense_heads/deformable_detr_head.py 41.60% <41.60%> (ø)
mmdet/models/dense_heads/detr_head.py 89.44% <50.00%> (+0.66%) ⬆️
mmdet/models/necks/channel_mapper.py 79.41% <53.33%> (-4.80%) ⬇️
mmdet/models/dense_heads/__init__.py 100.00% <100.00%> (ø)
mmdet/models/detectors/__init__.py 100.00% <100.00%> (ø)
mmdet/models/detectors/deformable_detr.py 100.00% <100.00%> (ø)
mmdet/models/detectors/cornernet.py 94.87% <0.00%> (-5.13%) ⬇️
mmdet/models/dense_heads/corner_head.py 73.72% <0.00%> (-1.88%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a856ef...a19c7f0. Read the comment docs.

@ZwwWayne ZwwWayne merged commit c709d38 into open-mmlab:master Apr 28, 2021
@jshilong jshilong deleted the re_deform_detr branch May 5, 2021 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants