Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MMCV's EvalHook in MMDetection #4806

Merged
merged 7 commits into from
May 26, 2021
Merged

Conversation

hhaAndroid
Copy link
Collaborator

@hhaAndroid hhaAndroid changed the title Use EvalHook in MMCV Use MMCV's EvalHook in MMDetection Mar 22, 2021
@ZwwWayne
Copy link
Collaborator

  1. CI failed.
  2. Need to keep the module in mmdet.core for at least a month and add warnings to avoid BC-breaking.

@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #4806 (b66fee2) into master (c6515a7) will increase coverage by 0.09%.
The diff coverage is 83.33%.

❗ Current head b66fee2 differs from pull request most recent head 5067930. Consider uploading reports for the commit 5067930 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4806      +/-   ##
==========================================
+ Coverage   65.17%   65.27%   +0.09%     
==========================================
  Files         269      269              
  Lines       20844    20733     -111     
  Branches     3500     3469      -31     
==========================================
- Hits        13586    13534      -52     
+ Misses       6492     6440      -52     
+ Partials      766      759       -7     
Flag Coverage Δ
unittests 65.24% <83.33%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/core/evaluation/eval_hooks.py 72.22% <83.33%> (+20.52%) ⬆️
mmdet/utils/logger.py 60.00% <0.00%> (-40.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6515a7...5067930. Read the comment docs.

@hhaAndroid hhaAndroid requested a review from xvjiarui May 19, 2021 11:07
@xvjiarui xvjiarui requested a review from ZwwWayne May 21, 2021 05:47
@ZwwWayne ZwwWayne merged commit 9e79ada into open-mmlab:master May 26, 2021
@hhaAndroid hhaAndroid deleted the evalhook branch March 19, 2022 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants