Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix supplement size in simple_test_bboxes #4860

Merged
merged 1 commit into from Mar 31, 2021
Merged

Fix supplement size in simple_test_bboxes #4860

merged 1 commit into from Mar 31, 2021

Conversation

yeliudev
Copy link
Contributor

@yeliudev yeliudev commented Mar 30, 2021

@hhaAndroid Thanks for your contributions on batch inference. I suggest changing the 5 to proposal.size(1) in case that sometimes proposals do not have scores (an N * 4 tensor) if they are loaded from files.

@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #4860 (ccc9515) into master (a5ee9b4) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head ccc9515 differs from pull request most recent head 5d62447. Consider uploading reports for the commit 5d62447 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4860      +/-   ##
==========================================
- Coverage   65.57%   65.52%   -0.05%     
==========================================
  Files         255      255              
  Lines       19981    19981              
  Branches     3398     3398              
==========================================
- Hits        13102    13093       -9     
- Misses       6176     6188      +12     
+ Partials      703      700       -3     
Flag Coverage Δ
unittests 65.49% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/models/roi_heads/test_mixins.py 49.01% <ø> (ø)
mmdet/models/detectors/cornernet.py 94.87% <0.00%> (-5.13%) ⬇️
mmdet/models/dense_heads/corner_head.py 73.72% <0.00%> (-1.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5ee9b4...5d62447. Read the comment docs.

@ZwwWayne ZwwWayne merged commit ff38f20 into open-mmlab:master Mar 31, 2021
ZwwWayne added a commit that referenced this pull request Apr 8, 2021
* Support Concatenate dataset for testing

* Support faster rcnn

* Fix Lint

* Add docstr

* Fix docstr

* Update docstr

* Allow onnx mrcnn

* Update code

* Update docstr

* MaskRCNN support batch infer

* Update

* Add mrcnn trt export

* [Refactor]: Add deprecate warnings of LoadImage (#4813)

* Remove LoadImage

* Add deprecation warning

* [feature] improve coco_error_analysis.py (#4712)

* add area name grouped map bar plots

* update function name, add comments, fix typo

* make all changes optional, add adjustable area region support, add area stat plots

* clean unnecessary comma

* [Fix]: minor syntax typo fix (#4836)

* [Feature]: Add mmdet2torchserve tool (#4810)

* Add mmdet_handler

* Add mmdet2torchserve

* Move serve to docker folder

* Support no gt test mode (#4827)

* Update doc

* Update docs

* Update docs

* Update 1_exist_data_model.md

Co-authored-by: Wenwei Zhang <40779233+ZwwWayne@users.noreply.github.com>

* [Feature]: Add Localization Distillation for Object Detection  (#4758)

* add Localization Distillation for Object Detection https://arxiv.org/abs/2102.12252

* fix lint

* fix lint

* fix lint

* fix lint

* fix lint

* fix config

* add kd detector

* edit loss name

* overide setattr but failed

* move init_detector into init

* seperate ld and gfocal, fix unused param error

* small fix

* small fix

* add test, reload magic function, create kd_loss.py

* del teacher model warnings

* fix reference

* add ignored bbox test fix docstring

* small fix

* docstring fix

* change names

* fix

* fix

* fix test

* fix import

* fix

* docstring fix

* fix

* retest

* add test

* docstring fix

* Fix some typos (#4858)

* Fix some typos

Signed-off-by: lizz <lizz@sensetime.com>

* More

Signed-off-by: lizz <lizz@sensetime.com>

* More

Signed-off-by: lizz <lizz@sensetime.com>

* More

Signed-off-by: lizz <lizz@sensetime.com>

* MaskRCNN support batch infer

* Update

* cherry pick commits to support maskrcnn with tensorrt

* Fix supplement size in simple_test_bboxes (#4860)

* Delete todo

* Fix error

* Use a unified add_dummy_nms_for_onnx for bbox_head

* Fix comments

* fix lint

* remove inplace operation and update doc

Co-authored-by: hhaAndroid <1286304229@qq.com>
Co-authored-by: David de la Iglesia Castro <daviddelaiglesiacastro@gmail.com>
Co-authored-by: fcakyon <34196005+fcakyon@users.noreply.github.com>
Co-authored-by: tczhao <evantczhao@gmail.com>
Co-authored-by: Wenwei Zhang <40779233+ZwwWayne@users.noreply.github.com>
Co-authored-by: HikariTJU <30501451+HikariTJU@users.noreply.github.com>
Co-authored-by: lizz <innerlee@users.noreply.github.com>
Co-authored-by: maningsheng <maningsheng@sensetime.com>
Co-authored-by: Ye Liu <yeliudev@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants